From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034148AbcIYHbf (ORCPT ); Sun, 25 Sep 2016 03:31:35 -0400 Received: from smtprelay0062.hostedemail.com ([216.40.44.62]:53651 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1031643AbcIYHbd (ORCPT ); Sun, 25 Sep 2016 03:31:33 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1042:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:2892:2895:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:7901:7903:10004:10400:10848:11026:11232:11473:11658:11914:12043:12050:12740:13069:13095:13255:13311:13357:13439:13894:14659:14721:21080:21212:21433:21451:30034:30054:30070:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: leg35_6479196e4cc57 X-Filterd-Recvd-Size: 2036 Message-ID: <1474788689.2238.3.camel@perches.com> Subject: Re: [PATCH v2 3/3] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect() From: Joe Perches To: SF Markus Elfring , linux-input@vger.kernel.org, Dmitry Torokhov Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Date: Sun, 25 Sep 2016 00:31:29 -0700 In-Reply-To: <814f7993-de4b-05d8-845e-3f0230122061@users.sourceforge.net> References: <1474733610.23838.2.camel@perches.com> <814f7993-de4b-05d8-845e-3f0230122061@users.sourceforge.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-09-25 at 09:15 +0200, SF Markus Elfring wrote: > 1. Add a definition for the macros "MY_LOG_PREFIX" and "pr_fmt" so that >   their information can be used for consistent message output. > > > 2. Prefer usage of the macro "pr_info" over the interface "printk" >   in this function. > > > 3. Reduce number of output function calls. > > > Signed-off-by: Markus Elfring > --- > > > v2: Yesterday a software development discussion pointed weaknesses out around >   the previous update steps "3" and "4". >   Now I propose this update variant in the hope that my second approach >   for this software module will work as desired and can be accepted >   a bit easier. No thank you. This is not a good change as it messes with dmesg timestamps. Simpler to read and more straightforward is multiple individual function calls.