From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941142AbcIYWWQ (ORCPT ); Sun, 25 Sep 2016 18:22:16 -0400 Received: from mga14.intel.com ([192.55.52.115]:35018 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751990AbcIYWWM (ORCPT ); Sun, 25 Sep 2016 18:22:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,396,1470726000"; d="asc'?scan'208";a="1045763051" Message-ID: <1474842129.2751.4.camel@intel.com> Subject: Re: [PATCH] ixgbe: mark symbols static where possible From: Jeff Kirsher To: Baoyou Xie , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn Date: Sun, 25 Sep 2016 15:22:09 -0700 In-Reply-To: <1474783438-7278-1-git-send-email-baoyou.xie@linaro.org> References: <1474783438-7278-1-git-send-email-baoyou.xie@linaro.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-rONEHRvWXWby2pI4vLer" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-rONEHRvWXWby2pI4vLer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2016-09-25 at 14:03 +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=3D1: > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no > previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes] > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning: no > previous prototype for 'ixgbe_led_off_t_x550em' [-Wmissing-prototypes] >=20 > In fact, these two functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. >=20 > Signed-off-by: Baoyou Xie > --- > =C2=A0drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 ++-- > =C2=A01 file changed, 2 insertions(+), 2 deletions(-) This has been fixed and pushed upstream, why do you keep submitting this? --=-rONEHRvWXWby2pI4vLer Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJX6E4SAAoJEOVv75VaS+3OjQEP/2XDMCehjn6qvM43aauu53AX Gn+j/07i3ekvBngTxsfsz3d9/jumJOktUrJ7uxPyqpkfzBTtx4IyLIgsUCAgdkwx +SOJ3aPMo6Sj/PRr4u/GJnf1esrp0VEIDjUCjWmqxWxvzCljPU6Q/MJr5QjX/oXT C2rkzcBMzAgaFVSyOU3r3FaFTCUJwYUqkj8OTq6HmluQyaMJn92yz3669Q9sEqsT 3CAx88d52SudPFuap4EMXQtS5FR+xFHg7Aqpob9biGdkPtnv+CbuU+bDcoKbKQM2 CCFxTqmsWFpUXfusHZCXW2jn3gxFxGUsGiLblD8P2hzWeQwQkNT+jkUqUiiWdKTz DRLkSiisyqNvIiHkrmlL67lkD4vzFI3lStfeLCHYRx0j76Qrl4QJCwEnma7qkYH/ cGi12YSCoqt5koZHlXUh1k5WEThI25+cUdKtjowypijUPayBtBFoREkRdx2r1GtP h3v3ocEWkOm3kDOYkTaFtlbQAludgSQ5jlJukBdxMmJr6XQ5TabyOSpoxr8AC56a 2oa2IrgFbkw+yJoZ3kj061fFDFo/Tyu2xBjNdotUNMFYDr0V/gn0MyJc++LewevS FiD3z8h4QANUgIPZaLyKmqc2ZHdOzZZFgWdRZfsx+sMaLDl+b21KT1CvY/+pwe+8 fBVooQf22JkFLvS6D2fa =/AbF -----END PGP SIGNATURE----- --=-rONEHRvWXWby2pI4vLer--