From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938660AbcIZJND (ORCPT ); Mon, 26 Sep 2016 05:13:03 -0400 Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:50930 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936366AbcIZJNA (ORCPT ); Mon, 26 Sep 2016 05:13:00 -0400 Message-ID: <1474881174.1846.8.camel@tiscali.nl> Subject: Re: [PATCH 3/5] ISDN-CAPI: Adjust 17 function calls together with variable assignments From: Paul Bolle To: SF Markus Elfring , netdev@vger.kernel.org, Karsten Keil Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Date: Mon, 26 Sep 2016 11:12:54 +0200 In-Reply-To: <10355972-1c9b-1103-edf3-efde78237cdd@users.sourceforge.net> References: <10355972-1c9b-1103-edf3-efde78237cdd@users.sourceforge.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-09-25 at 13:13 +0200, SF Markus Elfring wrote: > The script "checkpatch.pl" can point out that assignments should usually > not be performed within condition checks. > Thus move the assignment for a variable to a separate statement > in four functions. Did you recycle this commit explanation? Because git diff tells me you actually touched about eight functions.   > Signed-off-by: Markus Elfring > --- >  drivers/isdn/capi/capidrv.c | 59 +++++++++++++++++++++++++++------------------ >  1 file changed, 36 insertions(+), 23 deletions(-) So I ran checkpatch on this file, just like you did. Specifically, I did:  scripts/checkpatch.pl -f drivers/isdn/capi/capidrv.c | grep "assignment in if condition" | wc -l  It tells me there are actually 18 instances of this "ERROR". Why did you ignore one of it in this patch? Paul Bolle