* [PATCH] staging: skein: Remove extra blank lines
@ 2016-09-26 14:56 Martin
2016-09-26 16:26 ` Joe Perches
2016-09-27 7:18 ` Dan Carpenter
0 siblings, 2 replies; 4+ messages in thread
From: Martin @ 2016-09-26 14:56 UTC (permalink / raw)
To: gregkh, joe; +Cc: devel, linux-kernel, Martin
Fix coding style issue "multiple blank lines"
detected by checkpatch.pl in threefish_block.c file.
Signed-off-by: Martin <martin.alonso@zoho.com>
---
drivers/staging/skein/threefish_block.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/skein/threefish_block.c b/drivers/staging/skein/threefish_block.c
index a95563f..5064065 100644
--- a/drivers/staging/skein/threefish_block.c
+++ b/drivers/staging/skein/threefish_block.c
@@ -64,7 +64,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 += b1;
b1 = rol64(b1, 32) ^ b2;
-
b1 += k3 + t2;
b0 += b1 + k2;
b1 = rol64(b1, 14) ^ b0;
@@ -117,7 +116,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 += b1;
b1 = rol64(b1, 32) ^ b2;
-
b1 += k0 + t1;
b0 += b1 + k4;
b1 = rol64(b1, 14) ^ b0;
@@ -170,7 +168,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 += b1;
b1 = rol64(b1, 32) ^ b2;
-
b1 += k2 + t0;
b0 += b1 + k1;
b1 = rol64(b1, 14) ^ b0;
@@ -223,7 +220,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 += b1;
b1 = rol64(b1, 32) ^ b2;
-
b1 += k4 + t2;
b0 += b1 + k3;
b1 = rol64(b1, 14) ^ b0;
@@ -276,7 +272,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 += b1;
b1 = rol64(b1, 32) ^ b2;
-
b1 += k1 + t1;
b0 += b1 + k0;
b1 = rol64(b1, 14) ^ b0;
@@ -329,7 +324,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 += b1;
b1 = rol64(b1, 32) ^ b2;
-
b1 += k3 + t0;
b0 += b1 + k2;
b1 = rol64(b1, 14) ^ b0;
@@ -382,7 +376,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 += b1;
b1 = rol64(b1, 32) ^ b2;
-
b1 += k0 + t2;
b0 += b1 + k4;
b1 = rol64(b1, 14) ^ b0;
@@ -435,7 +428,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 += b1;
b1 = rol64(b1, 32) ^ b2;
-
b1 += k2 + t1;
b0 += b1 + k1;
b1 = rol64(b1, 14) ^ b0;
@@ -579,7 +571,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 -= b3 + k3 + t2;
b3 -= k4 + 16;
-
tmp = b3 ^ b0;
b3 = ror64(tmp, 32);
b0 -= b3;
@@ -648,7 +639,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 -= b3 + k1 + t0;
b3 -= k2 + 14;
-
tmp = b3 ^ b0;
b3 = ror64(tmp, 32);
b0 -= b3;
@@ -717,7 +707,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 -= b3 + k4 + t1;
b3 -= k0 + 12;
-
tmp = b3 ^ b0;
b3 = ror64(tmp, 32);
b0 -= b3;
@@ -786,7 +775,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 -= b3 + k2 + t2;
b3 -= k3 + 10;
-
tmp = b3 ^ b0;
b3 = ror64(tmp, 32);
b0 -= b3;
@@ -855,7 +843,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 -= b3 + k0 + t0;
b3 -= k1 + 8;
-
tmp = b3 ^ b0;
b3 = ror64(tmp, 32);
b0 -= b3;
@@ -924,7 +911,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 -= b3 + k3 + t1;
b3 -= k4 + 6;
-
tmp = b3 ^ b0;
b3 = ror64(tmp, 32);
b0 -= b3;
@@ -993,7 +979,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 -= b3 + k1 + t2;
b3 -= k2 + 4;
-
tmp = b3 ^ b0;
b3 = ror64(tmp, 32);
b0 -= b3;
@@ -1062,7 +1047,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
b2 -= b3 + k4 + t0;
b3 -= k0 + 2;
-
tmp = b3 ^ b0;
b3 = ror64(tmp, 32);
b0 -= b3;
--
2.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: skein: Remove extra blank lines
2016-09-26 14:56 [PATCH] staging: skein: Remove extra blank lines Martin
@ 2016-09-26 16:26 ` Joe Perches
2016-09-26 17:06 ` Martin Alonso
2016-09-27 7:18 ` Dan Carpenter
1 sibling, 1 reply; 4+ messages in thread
From: Joe Perches @ 2016-09-26 16:26 UTC (permalink / raw)
To: Martin, gregkh; +Cc: devel, linux-kernel
On Mon, 2016-09-26 at 11:56 -0300, Martin wrote:
> Fix coding style issue "multiple blank lines"
> detected by checkpatch.pl in threefish_block.c file.
This has been submitted and rejected a couple times already.
The extra blank lines are to separate blocks.
Whatever the blocks are, perhaps _adding_ a comment line
for each block might be better than removing a blank line.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: skein: Remove extra blank lines
2016-09-26 16:26 ` Joe Perches
@ 2016-09-26 17:06 ` Martin Alonso
0 siblings, 0 replies; 4+ messages in thread
From: Martin Alonso @ 2016-09-26 17:06 UTC (permalink / raw)
To: Joe Perches; +Cc: gregkh, devel, linux-kernel
Ok Joe,
Thanks and sorry for the annoyance.
On Mon, Sep 26, 2016 at 09:26:12AM -0700, Joe Perches wrote:
> On Mon, 2016-09-26 at 11:56 -0300, Martin wrote:
> > Fix coding style issue "multiple blank lines"
> > detected by checkpatch.pl in threefish_block.c file.
>
> This has been submitted and rejected a couple times already.
> The extra blank lines are to separate blocks.
> Whatever the blocks are, perhaps _adding_ a comment line
> for each block might be better than removing a blank line.
>
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: skein: Remove extra blank lines
2016-09-26 14:56 [PATCH] staging: skein: Remove extra blank lines Martin
2016-09-26 16:26 ` Joe Perches
@ 2016-09-27 7:18 ` Dan Carpenter
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-09-27 7:18 UTC (permalink / raw)
To: Martin; +Cc: gregkh, joe, devel, linux-kernel
On Mon, Sep 26, 2016 at 11:56:27AM -0300, Martin wrote:
> Fix coding style issue "multiple blank lines"
> detected by checkpatch.pl in threefish_block.c file.
>
> Signed-off-by: Martin <martin.alonso@zoho.com>
This Signed-off-by are like a legal document. Use first and last name.
Also fix your from header as well.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-27 7:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-26 14:56 [PATCH] staging: skein: Remove extra blank lines Martin
2016-09-26 16:26 ` Joe Perches
2016-09-26 17:06 ` Martin Alonso
2016-09-27 7:18 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox