From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163003AbcIZSCk (ORCPT ); Mon, 26 Sep 2016 14:02:40 -0400 Received: from smtprelay0080.hostedemail.com ([216.40.44.80]:47055 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1034290AbcIZSCh (ORCPT ); Mon, 26 Sep 2016 14:02:37 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3870:3873:4321:5007:7903:8603:8957:10004:10400:10848:11026:11232:11658:11914:12043:12048:12296:12681:12740:13069:13311:13357:13439:13894:14181:14659:14721:21080:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: mist45_8afec6d10dc2a X-Filterd-Recvd-Size: 1593 Message-ID: <1474912953.2238.17.camel@perches.com> Subject: Re: [PATCH] staging: vt6656: Add spaces around '+' operator From: Joe Perches To: Martin Alonso , forest@alittletooquiet.net, gregkh@linuxfoundation.org, pasteka@kabsi.at Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 26 Sep 2016 11:02:33 -0700 In-Reply-To: <1474912104-13501-1-git-send-email-martin.alonso@zoho.com> References: <1474912104-13501-1-git-send-email-martin.alonso@zoho.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-09-26 at 14:48 -0300, Martin Alonso wrote: > Fix coding style issue "spaces preferred around '+' > detected by checkpatch.pl in dpc.c file. [] > diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c [] > @@ -75,8 +75,8 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb, >   > >   skb_data = (u8 *)skb->data; >   > - rx_sts = skb_data+4; > - rx_rate = skb_data+5; > + rx_sts = skb_data + 4; > + rx_rate = skb_data + 5; >   >   /* real Frame Size = USBframe_size -4WbkStatus - 4RxStatus */ >   /* -8TSF - 4RSR - 4SQ3 - ?Padding */ You might as well make rx_rate u8 instead of u8 * and change the uses of rx_rate. rx_sts isn't used anywhere at all and could be removed.