From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966402AbcIZVxP (ORCPT ); Mon, 26 Sep 2016 17:53:15 -0400 Received: from mga14.intel.com ([192.55.52.115]:63666 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964926AbcIZVxN (ORCPT ); Mon, 26 Sep 2016 17:53:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,401,1470726000"; d="scan'208";a="13453693" Message-ID: <1474926791.3078.9.camel@linux.intel.com> Subject: Re: [PATCH] nvme-rdma: add missing \n to end of dev_err message From: J Freyensee To: Colin King , trivial@kernel.org, Keith Busch , Jens Axboe , linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org Date: Mon, 26 Sep 2016 14:53:11 -0700 In-Reply-To: <20160925220148.13300-1-colin.king@canonical.com> References: <20160925220148.13300-1-colin.king@canonical.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4 (3.20.4-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-09-25 at 15:01 -0700, Colin King wrote: > From: Colin Ian King > > Trival fix, dev_err message is missing a \n, so add it. Also > break line as it was over 80 chars wide. > > Signed-off-by: Colin Ian King Reviewed-by: Jay Freyensee > --- >  drivers/nvme/host/rdma.c | 3 ++- >  1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c > index 69e1fb7..3f32995 100644 > --- a/drivers/nvme/host/rdma.c > +++ b/drivers/nvme/host/rdma.c > @@ -1227,7 +1227,8 @@ static int nvme_rdma_conn_rejected(struct > nvme_rdma_queue *queue, >   (struct nvme_rdma_cm_rej *)ev- > >param.conn.private_data; >   >   dev_err(queue->ctrl->ctrl.device, > - "Connect rejected, status %d.", > le16_to_cpu(rej->sts)); > + "Connect rejected, status %d.\n", > + le16_to_cpu(rej->sts)); >   /* XXX: Think of something clever to do here... */ >   } else { >   dev_err(queue->ctrl->ctrl.device,