From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932180AbcI0HCf (ORCPT ); Tue, 27 Sep 2016 03:02:35 -0400 Received: from mail-db5eur01on0114.outbound.protection.outlook.com ([104.47.2.114]:45312 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751385AbcI0HC0 (ORCPT ); Tue, 27 Sep 2016 03:02:26 -0400 From: Marcel Ziswiler To: "shawnguo@kernel.org" , "maitysanchayan@gmail.com" CC: "stefan@agner.ch" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v2 1/3] ARM: dts: imx6qdl-apalis: Do not rely on DDC I2C bus bitbang for HDMI Thread-Topic: [PATCH v2 1/3] ARM: dts: imx6qdl-apalis: Do not rely on DDC I2C bus bitbang for HDMI Thread-Index: AQHSEjV7qUdH8nDGGkyz3xJuTcfIpKCM7F6A Date: Tue, 27 Sep 2016 06:28:43 +0000 Message-ID: <1474957723.3739.3.camel@toradex.com> References: <2263d508999ada9476268138b2922702eb50131f.1474260360.git.maitysanchayan@gmail.com> In-Reply-To: <2263d508999ada9476268138b2922702eb50131f.1474260360.git.maitysanchayan@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=marcel.ziswiler@toradex.com; x-originating-ip: [84.227.37.153] x-ms-office365-filtering-correlation-id: b9cf3926-9451-49c3-8019-08d3e69f8798 x-microsoft-exchange-diagnostics: 1;HE1PR05MB1882;6:TSqSs+uHTrOzU/cTGHcOQWjB1XEeoiDNWkyoeWikUR9JF7tQuPNT/W0U7HGL2XkIVM13C0nuMCK75L5Sf/RTBrtDPvcKN0q6HGTd9WXOD+BXcbgV0LQ0Ajj9BWKh4un/suEFF+ZtpGpwjs8HkXy2RLCoK3ziZwHEGXXHdUYmAOl7bZZPS42vjpiVEBFVz2dUQObg0+z/rQx0o3vVccZ3lYCXrUb5HKHUrTxZ/z/qjwTvYamCEdb+HeWS1cfrF9y0GCdOq5uXkm8vNg4r8glVtbX2Q3lTW+y/3bPujf2H2e8=;5:zpt0pIPC9LmIJKdUkoR0Fvztu6Bk1F8pUlGCX2FCl/CN81IXkE6kMUvmpc0TEFRkn1Wns75/UW2ju5PvI4lSeIvsnOwdTm94soIBSUvWojSxckytLnAMGymSM3YjLvaT74oGuOFC8EKV/jKwoNqyiQ==;24:2oockNb5HyJePFqh+Xmw+HDat470eI6Ryk8GOEcbLClqerTDVhkPxajZFVdhHAykOm6lFmyEOgk5+c/Fm25N8qWINfLQkPEVDMeIghOhPOQ=;7:C8U6ffywZoaGIlkkiws0VFcpiHMuPTm4tvTJBa61R1AeThDaYF4HJIcgvnYGyz9hl4PVS3kmVGEsGLi7zb0UhHuBoYHzzt5ICpxYNFS+uHg7WdkmMXTz7Dgw/LM5QNSaOJ2s3leg7r+te906wzMNTaunLfcPeTpRK5rjxzJuZPo+VyB1eE2JLej+vNfL6K7Je5mUMRh0xfgKPQNvuoFZWJm4zn6oFPNFKzNlUhYVtOpHCXK5LF3Xvrg23jFDJc1xkJm6LQjI79vFi15ivjmPoQ6g5inCAeeOOf1GE3G3lAPHfwFE5jNy9zrGWVWyr086 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1882; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:HE1PR05MB1882;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1882; x-forefront-prvs: 007814487B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(199003)(24454002)(377424004)(189002)(3660700001)(87936001)(11100500001)(92566002)(19580405001)(19580395003)(4326007)(10400500002)(575784001)(86362001)(54356999)(76176999)(50986999)(2950100002)(5002640100001)(2501003)(66066001)(33646002)(36756003)(97736004)(5001770100001)(5660300001)(77096005)(15975445007)(101416001)(3280700002)(81166006)(81156014)(2900100001)(189998001)(8936002)(2906002)(7846002)(586003)(103116003)(122556002)(8676002)(68736007)(102836003)(106356001)(6116002)(106116001)(3846002)(305945005)(105586002)(7736002)(32563001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR05MB1882;H:HE1PR05MB1882.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <0DC1F18BD985CF49BD865C41CAD7CA02@eurprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2016 06:28:43.6417 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1882 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u8R72ioU006831 On Mon, 2016-09-19 at 10:41 +0530, Sanchayan Maity wrote: > Remove the use of DDC I2C bus bitbang to support reading of EDID > and rely on support from internal HDMI I2C master controller instead. > As a result remove the device tree property ddc-i2c-bus. > > Signed-off-by: Sanchayan Maity Acked-by: Marcel Ziswiler > --- > Changes since v1: > > Change the ranking in i2c aliases > > v1: https://lkml.org/lkml/2016/9/14/55 > --- >  arch/arm/boot/dts/imx6q-apalis-ixora.dts | 12 +++--------- >  arch/arm/boot/dts/imx6qdl-apalis.dtsi    | 25 +++++++++------------- > --- >  2 files changed, 12 insertions(+), 25 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6q-apalis-ixora.dts > b/arch/arm/boot/dts/imx6q-apalis-ixora.dts > index 207b85b..82b81e0 100644 > --- a/arch/arm/boot/dts/imx6q-apalis-ixora.dts > +++ b/arch/arm/boot/dts/imx6q-apalis-ixora.dts > @@ -55,10 +55,9 @@ >        "fsl,imx6q"; >   >   aliases { > - i2c0 = &i2cddc; > - i2c1 = &i2c1; > - i2c2 = &i2c2; > - i2c3 = &i2c3; > + i2c0 = &i2c1; > + i2c1 = &i2c2; > + i2c2 = &i2c3; >   }; >   >   aliases { > @@ -186,11 +185,6 @@ >  }; >   >  &hdmi { > - ddc-i2c-bus = <&i2cddc>; > - status = "okay"; > -}; > - > -&i2cddc { >   status = "okay"; >  }; >   > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > index 99e323b..8c67dd8 100644 > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > @@ -53,18 +53,6 @@ >   status = "disabled"; >   }; >   > - /* DDC_I2C: I2C2_SDA/SCL on MXM3 205/207 */ > - i2cddc: i2c@0 { > - compatible = "i2c-gpio"; > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_i2c_ddc>; > - gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */ > -  &gpio2 30 GPIO_ACTIVE_HIGH /* scl */ > - >; > - i2c-gpio,delay-us = <2>; /* ~100 kHz */ > - status = "disabled"; > - }; > - >   reg_1p8v: regulator-1p8v { >   compatible = "regulator-fixed"; >   regulator-name = "1P8V"; > @@ -209,6 +197,12 @@ >   }; >  }; >   > +&hdmi { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_hdmi_ddc>; > + status = "disabled"; > +}; > + >  /* >   * GEN1_I2C: I2C1_SDA/SCL on MXM3 209/211 (e.g. RTC on carrier >   * board) > @@ -633,11 +627,10 @@ >   >; >   }; >   > - pinctrl_i2c_ddc: gpioi2cddcgrp { > + pinctrl_hdmi_ddc: hdmiddcgrp { >   fsl,pins = < > - /* DDC bitbang */ > - MX6QDL_PAD_EIM_EB2__GPIO2_IO30 0x1b0b0 > - MX6QDL_PAD_EIM_D16__GPIO3_IO16 0x1b0b0 > + MX6QDL_PAD_EIM_EB2__HDMI_TX_DDC_SCL > 0x4001b8b1 > + MX6QDL_PAD_EIM_D16__HDMI_TX_DDC_SDA > 0x4001b8b1 >   >; >   };