From: Joe Perches <joe@perches.com>
To: Ramiro Oliveira <Ramiro.Oliveira@synopsys.com>,
gregkh@linuxfoundation.org, arve@android.com,
riandrews@android.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: android: fix permissions style
Date: Tue, 27 Sep 2016 10:43:48 -0700 [thread overview]
Message-ID: <1474998228.2731.18.camel@perches.com> (raw)
In-Reply-To: <d95de5aeb5723864667004bdc4741fae9b8947e7.1474923269.git.roliveir@synopsys.com>
On Mon, 2016-09-26 at 22:02 +0100, Ramiro Oliveira wrote:
> Change permissions from symbolic to octal.
[]
> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
[]
> @@ -204,10 +204,10 @@ device_initcall(lowmem_init);
> * not really modular, but the easiest way to keep compat with existing
> * bootargs behaviour is to continue using module_param here.
> */
> -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
> +module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
> module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size,
> > S_IRUGO | S_IWUSR);
> module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size,
> S_IRUGO | S_IWUSR);
Seems odd to fix the other two but not this one.
> -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
> +module_param_named(debug_level, lowmem_debug_level, uint, 0644);
next prev parent reply other threads:[~2016-09-27 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 21:02 [PATCH] Staging: android: fix permissions style Ramiro Oliveira
2016-09-27 17:43 ` Joe Perches [this message]
2016-09-28 9:28 ` Greg KH
2016-09-28 13:48 ` Ramiro Oliveira
2016-09-28 15:37 ` Greg KH
2016-09-28 15:49 ` Ramiro Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474998228.2731.18.camel@perches.com \
--to=joe@perches.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox