linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Alonso <martin.alonso@zoho.com>
To: joe@perches.com, forest@alittletooquiet.net,
	gregkh@linuxfoundation.org, pasteka@kabsi.at
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Martin Alonso <martin.alonso@zoho.com>
Subject: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 *
Date: Tue, 27 Sep 2016 14:52:49 -0300	[thread overview]
Message-ID: <1474998769-29646-2-git-send-email-martin.alonso@zoho.com> (raw)
In-Reply-To: <1474998769-29646-1-git-send-email-martin.alonso@zoho.com>

Change the type and uses of rx_rate.

Signed-off-by: Martin Alonso <martin.alonso@zoho.com>
---
 drivers/staging/vt6656/dpc.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c
index 655f000..782b7d7 100644
--- a/drivers/staging/vt6656/dpc.c
+++ b/drivers/staging/vt6656/dpc.c
@@ -46,7 +46,8 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
 	__le64 *tsf_time;
 	u32 frame_size;
 	int ii, r;
-	u8 *rx_rate, *sq, *sq_3;
+	u8 rx_rate;
+	u8 *sq, *sq_3;
 	u32 wbk_status;
 	u8 *skb_data;
 	u16 *pay_load_len;
@@ -75,7 +76,7 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
 
 	skb_data = (u8 *)skb->data;
 
-	rx_rate = skb_data + 5;
+	rx_rate = *(skb_data + 5);
 
 	/* real Frame Size = USBframe_size -4WbkStatus - 4RxStatus */
 	/* -8TSF - 4RSR - 4SQ3 - ?Padding */
@@ -96,7 +97,7 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
 	sband = hw->wiphy->bands[hw->conf.chandef.chan->band];
 
 	for (r = RATE_1M; r < MAX_RATE; r++) {
-		if (*rx_rate == rate[r])
+		if (rx_rate == rate[r])
 			break;
 	}
 
@@ -110,7 +111,7 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
 	}
 
 	if (ii == sband->n_bitrates) {
-		dev_dbg(&priv->usb->dev, "Wrong RxRate %x\n", *rx_rate);
+		dev_dbg(&priv->usb->dev, "Wrong RxRate %x\n", rx_rate);
 		return false;
 	}
 
-- 
2.8.0

  reply	other threads:[~2016-09-27 17:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26 17:48 [PATCH] staging: vt6656: Add spaces around '+' operator Martin Alonso
2016-09-26 18:02 ` Joe Perches
2016-09-27 16:59   ` Martin Alonso
2016-09-27 17:52     ` [PATCH 1/2] staging: vt6656: Remove unused variable 'rx_sts' Martin Alonso
2016-09-27 17:52       ` Martin Alonso [this message]
2016-09-28  7:40         ` [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Dan Carpenter
2016-09-30 18:53           ` Malcolm Priestley
2016-09-30 19:37             ` Dan Carpenter
2016-09-28  9:34         ` Greg KH
2016-09-27 11:10 ` [PATCH] staging: vt6656: Add spaces around '+' operator Greg KH
2016-09-27 11:49   ` Martin Alonso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474998769-29646-2-git-send-email-martin.alonso@zoho.com \
    --to=martin.alonso@zoho.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasteka@kabsi.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).