From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754574AbcGHLQT (ORCPT ); Fri, 8 Jul 2016 07:16:19 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:48700 "EHLO mx4-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754262AbcGHLQK (ORCPT ); Fri, 8 Jul 2016 07:16:10 -0400 Date: Fri, 8 Jul 2016 07:15:39 -0400 (EDT) From: Paolo Bonzini To: Borislav Petkov Cc: Eduardo Habkost , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, stable@vger.kernel.org, Yazen Ghannam , Brijesh Singh Message-ID: <1475224135.5251432.1467976539798.JavaMail.zimbra@redhat.com> In-Reply-To: <20160708110900.GF3808@pd.tnic> References: <20160707104128.GC13648@pd.tnic> <20160707124712.GE13648@pd.tnic> <21b7a239-5fac-b6bf-a48f-71fa456a9c97@redhat.com> <20160707160146.GH13648@pd.tnic> <20160707162755.GD4131@thinpad.lan.raisama.net> <20160707170442.GK13648@pd.tnic> <20160707174349.GH4131@thinpad.lan.raisama.net> <20160708110900.GF3808@pd.tnic> Subject: Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.4.164.1, 10.5.101.130] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF47 (Linux)/8.0.6_GA_5922) Thread-Topic: fix trashing of MSR_TSC_AUX Thread-Index: mDQNx5V0pmrb3rXdb18DJbi/f/54Lw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Ok, I'll go through the features and see what kind of state the kernel > programs in there and add them to a VMStateDescription thing. Hohumm, > makes sense to me. It does sometimes happen that there is no state. For example it could be an MSR that we are already getting in and out of KVM. However, it is way more common that you have to add support for reading/writing the MSR in KVM as well, and then teach QEMU's target-i386/kvm.c about it as well. It's hard to say without knowing exactly what the feature is about... Is there an architecture manual out there that documents it? Paolo