From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbcJIRro (ORCPT ); Sun, 9 Oct 2016 13:47:44 -0400 Received: from smtprelay0042.hostedemail.com ([216.40.44.42]:33477 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751947AbcJIRrn (ORCPT ); Sun, 9 Oct 2016 13:47:43 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2194:2198:2199:2200:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3868:3870:3873:4321:4605:5007:10004:10400:10848:11026:11232:11658:11914:12043:12048:12296:12438:12740:12760:13069:13095:13146:13230:13311:13357:13439:14659:14721:21080:21433:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: end61_1b579079d8c06 X-Filterd-Recvd-Size: 1602 Message-ID: <1476035186.2856.9.camel@perches.com> Subject: Re: [PATCH V2] staging: ks7010: use netdev_* instead of printk() From: Joe Perches To: Sabitha George , gregkh@linuxfoundation.org, wsa+renesas@sang-engineering.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 09 Oct 2016 10:46:26 -0700 In-Reply-To: <1476030845-8674-1-git-send-email-sabitha.george@gmail.com> References: <1476030845-8674-1-git-send-email-sabitha.george@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.0-2ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-10-09 at 22:04 +0530, Sabitha George wrote: > Fixes checkpatch warning on printk usage in ks_hostif.c [] > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c [] > @@ -465,8 +465,7 @@ void hostif_data_indication(struct ks_wlan_private *priv) > skb->dev->last_rx = jiffies; > netif_rx(skb); > } else { > - printk(KERN_WARNING > - "ks_wlan: Memory squeeze, dropping packet.\n"); > + netdev_warn(priv->net_dev, "ks_wlan: Memory squeeze, dropping packet.\n"); You could probably drop all the "ks_wlan: " prefixes here and the rx_dropped increase generally removes the need for a non-rate-limited warning message so these memory squeeze messages could be removed as well.