From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Oliver Neukum <oneukum@suse.com>,
Alan Stern <stern@rowland.harvard.edu>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Pawel Moll <pawel.moll@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Alan Cooper <alcooperx@gmail.com>, <linux-usb@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [RESEND PATCH v6, 4/5] usb: Add MediaTek USB3 DRD Driver
Date: Tue, 11 Oct 2016 11:14:23 +0800 [thread overview]
Message-ID: <1476155663.15546.32.camel@mhfsdcap03> (raw)
In-Reply-To: <49293f1b-42b5-f06b-8fdc-f46fe996e237@gmail.com>
On Mon, 2016-10-10 at 13:00 +0200, Matthias Brugger wrote:
>
> On 09/21/2016 07:54 AM, Chunfeng Yun wrote:
> > This patch adds support for the MediaTek USB3 controller
> > integrated into MT8173. It can be configured as Dual-Role
> > Device (DRD), Peripheral Only and Host Only (xHCI) modes.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > drivers/usb/Kconfig | 2 +
> > drivers/usb/Makefile | 1 +
> > drivers/usb/mtu3/Kconfig | 54 +++
> > drivers/usb/mtu3/Makefile | 19 +
> > drivers/usb/mtu3/mtu3.h | 422 +++++++++++++++++
> > drivers/usb/mtu3/mtu3_core.c | 871 +++++++++++++++++++++++++++++++++++
> > drivers/usb/mtu3/mtu3_dr.c | 379 ++++++++++++++++
> > drivers/usb/mtu3/mtu3_dr.h | 108 +++++
> > drivers/usb/mtu3/mtu3_gadget.c | 731 +++++++++++++++++++++++++++++
> > drivers/usb/mtu3/mtu3_gadget_ep0.c | 883 ++++++++++++++++++++++++++++++++++++
> > drivers/usb/mtu3/mtu3_host.c | 294 ++++++++++++
> > drivers/usb/mtu3/mtu3_hw_regs.h | 473 +++++++++++++++++++
> > drivers/usb/mtu3/mtu3_plat.c | 490 ++++++++++++++++++++
> > drivers/usb/mtu3/mtu3_qmu.c | 599 ++++++++++++++++++++++++
> > drivers/usb/mtu3/mtu3_qmu.h | 43 ++
> > 15 files changed, 5369 insertions(+)
> > create mode 100644 drivers/usb/mtu3/Kconfig
> > create mode 100644 drivers/usb/mtu3/Makefile
> > create mode 100644 drivers/usb/mtu3/mtu3.h
> > create mode 100644 drivers/usb/mtu3/mtu3_core.c
> > create mode 100644 drivers/usb/mtu3/mtu3_dr.c
> > create mode 100644 drivers/usb/mtu3/mtu3_dr.h
> > create mode 100644 drivers/usb/mtu3/mtu3_gadget.c
> > create mode 100644 drivers/usb/mtu3/mtu3_gadget_ep0.c
> > create mode 100644 drivers/usb/mtu3/mtu3_host.c
> > create mode 100644 drivers/usb/mtu3/mtu3_hw_regs.h
> > create mode 100644 drivers/usb/mtu3/mtu3_plat.c
> > create mode 100644 drivers/usb/mtu3/mtu3_qmu.c
> > create mode 100644 drivers/usb/mtu3/mtu3_qmu.h
> >
>
> As Oliver already said, this patch is quiet big which makes it difficult
> to review.
> I propose to provide a first implementation with minimal functionality
> and incremental patches on top of this when the first got merged.
>
> You could split the patch in three series/parts:
> 1. Host only
> 2. Peripheral only
> 3. Dual mode
>
> What do you think?
Ok, I'll split the patch into some small ones as many as possible.
Thanks a lot
>
> Regards,
> Matthias
>
next prev parent reply other threads:[~2016-10-11 3:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 5:54 [RESEND PATCH v6, 0/5] Add MediaTek USB3 DRD Driver Chunfeng Yun
2016-09-21 5:54 ` [RESEND PATCH v6, 1/5] dt-bindings: mt8173-xhci: support host side of dual-role mode Chunfeng Yun
2016-09-21 5:54 ` [RESEND PATCH v6, 2/5] dt-bindings: mt8173-mtu3: add devicetree bindings Chunfeng Yun
2016-09-21 5:54 ` [RESEND PATCH v6, 3/5] usb: xhci-mtk: make IPPC register optional Chunfeng Yun
2016-10-09 6:50 ` Chunfeng Yun
2016-10-10 10:55 ` Matthias Brugger
2016-10-11 2:44 ` Chunfeng Yun
2016-09-21 5:54 ` [RESEND PATCH v6, 4/5] usb: Add MediaTek USB3 DRD Driver Chunfeng Yun
2016-10-10 11:00 ` Matthias Brugger
2016-10-11 3:14 ` Chunfeng Yun [this message]
2016-10-11 10:23 ` Matthias Brugger
2016-09-21 5:54 ` [RESEND PATCH v6, 5/5] arm64: dts: mediatek: add USB3 DRD driver Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476155663.15546.32.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=alcooperx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=oneukum@suse.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox