From: Ian Kent <raven@themaw.net>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
autofs mailing list <autofs@vger.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Omar Sandoval <osandov@osandov.com>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 1/8] vfs - change d_manage() to take a struct path
Date: Wed, 12 Oct 2016 07:47:29 +0800 [thread overview]
Message-ID: <1476229649.3108.1.camel@themaw.net> (raw)
In-Reply-To: <87zimazxcc.fsf@x220.int.ebiederm.org>
On Tue, 2016-10-11 at 11:04 -0500, Eric W. Biederman wrote:
> Ian Kent <raven@themaw.net> writes:
>
> > For the autofs module to be able to reliably check if a dentry is a
> > mountpoint in a multiple namespace environment the ->d_manage() dentry
> > operation will need to take a path argument instead of a dentry.
>
> Taking a quick look overall I see no issues with this series. Overall
> it seems straight forward.
>
> On the nit side I expect saying const struct path * in the functions
> that now take a struct path would be useful.
>
> I suspect it would also be useful to say
> const struct path *path;
> path = &file->f_path;
>
> In the one part of the code where you do that. Instead of copying the
> path out of the struct file.
>
> Overall I expect that will keep down bugs at no reduction in usability.
> Just a statement that the struct path won't change when it is passed
> to various functions.
Thanks Eric, that's a good suggestion for a follow up patch, will do.
Ian
next prev parent reply other threads:[~2016-10-11 23:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 5:33 [PATCH 1/8] vfs - change d_manage() to take a struct path Ian Kent
2016-10-11 5:33 ` [PATCH 2/8] vfs - add path_is_mountpoint() helper Ian Kent
2016-10-11 5:34 ` [PATCH 3/8] vfs - add path_has_submounts() Ian Kent
2016-10-11 5:34 ` [PATCH 4/8] autofs - change autofs4_expire_wait() to take struct path Ian Kent
2016-10-11 5:34 ` [PATCH 5/8] autofs - change autofs4_wait() " Ian Kent
2016-10-11 5:34 ` [PATCH 6/8] autofs - use path_is_mountpoint() to fix unreliable d_mountpoint() checks Ian Kent
2016-10-27 2:17 ` Al Viro
2016-10-27 2:51 ` Ian Kent
2016-10-11 5:34 ` [PATCH 7/8] autofs - use path_has_submounts() to fix unreliable have_submount() checks Ian Kent
2016-10-11 5:34 ` [PATCH 8/8] vfs - remove unused have_submounts() function Ian Kent
2016-10-11 16:04 ` [PATCH 1/8] vfs - change d_manage() to take a struct path Eric W. Biederman
2016-10-11 23:47 ` Ian Kent [this message]
2016-10-19 19:40 ` Andrew Morton
2016-10-20 23:39 ` Ian Kent
2016-10-27 2:11 ` Al Viro
2016-10-27 2:47 ` Ian Kent
2016-10-27 6:50 ` Ian Kent
2016-11-01 2:02 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476229649.3108.1.camel@themaw.net \
--to=raven@themaw.net \
--cc=akpm@linux-foundation.org \
--cc=autofs@vger.kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox