From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753589AbcJMKU6 (ORCPT ); Thu, 13 Oct 2016 06:20:58 -0400 Received: from smtprelay0029.hostedemail.com ([216.40.44.29]:35757 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753198AbcJMKUy (ORCPT ); Thu, 13 Oct 2016 06:20:54 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2110:2393:2559:2562:2828:2892:3138:3139:3140:3141:3142:3353:3622:3742:3865:3866:3867:3868:3870:3871:3874:4321:5007:9007:10004:10400:10482:10848:11232:11658:11914:12296:12663:12740:13069:13076:13095:13311:13357:13439:13894:14180:14659:14721:19901:19997:21067:21080:21433:30054:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: burn79_77a62b3d8c46 X-Filterd-Recvd-Size: 2590 Message-ID: <1476354050.2164.7.camel@perches.com> Subject: Re: linux.git: printk() problem From: Joe Perches To: Michal Hocko Cc: Tetsuo Handa , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, Colin Ian King Date: Thu, 13 Oct 2016 03:20:50 -0700 In-Reply-To: <20161013100438.GH21678@dhcp22.suse.cz> References: <201610122230.DID43237.FSOHFFQOJOtVML@I-love.SAKURA.ne.jp> <20161012143525.GD9523@dhcp22.suse.cz> <1476288538.16823.9.camel@perches.com> <20161013062600.GB21678@dhcp22.suse.cz> <1476350986.2164.3.camel@perches.com> <20161013100438.GH21678@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.0-2ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-10-13 at 12:04 +0200, Michal Hocko wrote: > On Thu 13-10-16 02:29:46, Joe Perches wrote: > > On Thu, 2016-10-13 at 08:26 +0200, Michal Hocko wrote: > > [...] > > > I think they are not critical and can be fix once somebody notices. > > > > > > As do I, but Linus objected to applying a patch when Colin Ian King > > noticed one. > > > > I think the 250,000 or so uses with newlines are enough of a > > precedence to keep using newlines everywhere. > > > or simply fix missing KERN_CONTs and simply do not add any new missing \n > > > Now we'll have to have patches adding hundreds to thousands of the > > missing KERN_CONTs for continuation lines that weren't previously a > > problem in logging output but are now. > > > I would be really surprised if we really had that many continuation > lines. They should be avoided as much as possible. Hundreds of thousands > just sounds more than over exaggerated... Hey Michal. "Hundreds _to_ thousands" of instances. Not "hundreds _of_ thousands". > Not requiring \n at the end of strings just makes a lot of sense if we > have a KERN_CONT with a well defined semantic. True enough. And I am not at all arguing against having a well defined KERN_CONT semantic. But using KERN_CONT alone is not enough information to be able to perfectly reassemble message fragments post hoc given multiple threads possibly interleaving KERN_CONT. I do think the inconsistency of mixing styles with and without newlines not particularly good. cheers, Joe