From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756772AbbICPjN (ORCPT ); Thu, 3 Sep 2015 11:39:13 -0400 Received: from mail.efficios.com ([78.47.125.74]:42684 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754586AbbICPjK (ORCPT ); Thu, 3 Sep 2015 11:39:10 -0400 Date: Thu, 3 Sep 2015 15:38:58 +0000 (UTC) From: Mathieu Desnoyers To: Will Deacon Cc: Andrew Morton , linux-api , linux-kernel@vger.kernel.org, Catalin Marinas Message-ID: <1476370440.35879.1441294738582.JavaMail.zimbra@efficios.com> In-Reply-To: <20150902101049.GE25720@arm.com> References: <1440698215-8355-1-git-send-email-mathieu.desnoyers@efficios.com> <1440698215-8355-4-git-send-email-mathieu.desnoyers@efficios.com> <20150902101049.GE25720@arm.com> Subject: Re: [RFC PATCH 3/9] arm64: allocate sys_membarrier system call number MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [78.47.125.74] X-Mailer: Zimbra 8.6.0_GA_1178 (ZimbraWebClient - FF40 (Linux)/8.6.0_GA_1178) Thread-Topic: arm64: allocate sys_membarrier system call number Thread-Index: bLXnQkrQox7GcgW5wRW+HVdFk8hjTQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On Sep 2, 2015, at 6:10 AM, Will Deacon will.deacon@arm.com wrote: > On Thu, Aug 27, 2015 at 06:56:49PM +0100, Mathieu Desnoyers wrote: >> arm64 sys_membarrier number is already wired for arm64 through >> asm-generic/unistd.h, but needs to be allocated separately for >> the 32-bit compability layer of arm64. >> >> [ Untested on this architecture. To try it out: fetch linux-next/akpm, >> apply this patch, build/run a membarrier-enabled kernel, and do make >> kselftest. ] >> >> Signed-off-by: Mathieu Desnoyers >> CC: Andrew Morton >> CC: linux-api@vger.kernel.org >> CC: Catalin Marinas >> CC: Will Deacon >> --- >> arch/arm64/include/asm/unistd32.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/include/asm/unistd32.h >> b/arch/arm64/include/asm/unistd32.h >> index cef934a..d97be80 100644 >> --- a/arch/arm64/include/asm/unistd32.h >> +++ b/arch/arm64/include/asm/unistd32.h >> @@ -797,3 +797,5 @@ __SYSCALL(__NR_memfd_create, sys_memfd_create) >> __SYSCALL(__NR_bpf, sys_bpf) >> #define __NR_execveat 387 >> __SYSCALL(__NR_execveat, compat_sys_execveat) >> +#define __NR_membarrier 388 >> +__SYSCALL(__NR_membarrier, sys_membarrier) > > I think people have made similar comments for other architectures, but > please also updated __NR_compat_syscalls when adding new compat syscalls > here. Thanks for pointing it out! I'm fixing it for the next RFC round. Mathieu > > Will -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com