public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Linux Weekly News <lwn@lwn.net>,
	Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 05/27] perf tools: Handle completion of upper case events
Date: Thu, 13 Oct 2016 13:21:18 -0300	[thread overview]
Message-ID: <1476375700-8896-6-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1476375700-8896-1-git-send-email-acme@kernel.org>

From: Andi Kleen <ak@linux.intel.com>

Vendor events are often specified in upper case. perf list outputs them
in lower case. Handle this case in perf-completion.sh so that completion
on the upper case events still works.

v2: Use locale aware check for upper case
v3: Use perf list json

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/1475781807-6034-2-git-send-email-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/perf-completion.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
index 3ba80b2359cc..3b5a258a4b7b 100644
--- a/tools/perf/perf-completion.sh
+++ b/tools/perf/perf-completion.sh
@@ -161,7 +161,11 @@ __perf_main ()
 	# List possible events for -e option
 	elif [[ $prev == @("-e"|"--event") &&
 		$prev_skip_opts == @(record|stat|top) ]]; then
-		evts=$($cmd list --raw-dump)
+		# handle upper case events
+		case "$cur" in
+			[[:upper:]]*) evts=$($cmd list --raw-dump json | tr a-z A-Z) ;;
+			*) evts=$($cmd list --raw-dump) ;;
+		esac
 		__perfcomp_colon "$evts" "$cur"
 	else
 		# List subcommands for perf commands
-- 
2.7.4

  parent reply	other threads:[~2016-10-13 16:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13 16:21 [GIT PULL 00/27] perf/urgent fixes and JSON events files Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 01/27] perf top: Fix refreshing hierarchy entries on TUI Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 02/27] perf header: Set nr_numa_nodes only when we parsed all the data Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 03/27] perf jevents: Handle events including .c and .o Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 04/27] perf list: Add support for listing only json events Arnaldo Carvalho de Melo
2016-10-16  6:53   ` Ingo Molnar
2016-10-17 13:57     ` Andi Kleen
2016-10-17 14:28       ` [GIT PULL] " Arnaldo Carvalho de Melo
2016-10-17 14:49         ` Ingo Molnar
2016-10-13 16:21 ` Arnaldo Carvalho de Melo [this message]
2016-10-13 16:21 ` [PATCH 06/27] perf jevents: Add BroadwellDE V5 event file Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 07/27] perf jevents: Add Broadwell V17 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 08/27] perf jevents: Add BroadwellX V10 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 09/27] perf jevents: Add Bonnell V4 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 10/27] perf jevents: Add Goldmont V8 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 11/27] perf jevents: Add Haswell V24 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 12/27] perf jevents: Add HaswellX V17 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 13/27] perf jevents: Add IvyBridge V18 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 14/27] perf jevents: Add IvyTown V19 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 15/27] perf jevents: Add Jaketown V20 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 16/27] perf jevents: Add KnightsLanding V9 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 17/27] perf jevents: Add NehalemEP V2 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 18/27] perf jevents: Add NehalemEX " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 19/27] perf jevents: Add Skylake V24 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 20/27] perf jevents: Add Silvermont V13 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 21/27] perf jevents: Add SandyBridge V15 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 22/27] perf jevents: Add WestmereEP-DP V2 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 23/27] perf jevents: Add WestmereEP-SP " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 24/27] perf jevents: Add WestmereEX " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 25/27] perf jevents: Add power8 PMU events Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 26/27] perf jevents: Support couple more POWER8 PVRs in mapfile Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 27/27] perf jit: Fix build issue on Ubuntu Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476375700-8896-6-git-send-email-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lwn@lwn.net \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox