Re: [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts

Jagan Teki
2016-10-21T07:55:57Z

On Fri, Oct 21, 2016 at 7:05 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Tue, Oct 18, 2016 at 05:30:28PM +0530, Jagan Teki wrote:
>> Hi Shawn,
>>
>> On Fri, Oct 14, 2016 at 2:57 PM, Jagan Teki <jteki@openedev.com> wrote:
>> > This is series add dts support for Engicam I.Core M6 qdl modules. just
>> > rebased on top of linux-next of previous set[1].
>> >
>> > [1] http://www.spinics.net/lists/kernel/msg2358233.html
>> >
>> > Jagan Teki (5):
>> > ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support
>> > ARM: dts: imx6q: Add Engicam i.CoreM6 DualLite/Solo initial support
>> > ARM: dts: imx6qdl-icore: Add usbhost support
>> > ARM: dts: imx6qdl-icore: Add usbotg support
>> > ARM: dts: imx6qdl-icore: Add FEC support
>> >
>> > arch/arm/boot/dts/Makefile | 2 +
>> > arch/arm/boot/dts/imx6dl-icore.dts | 59 ++++++++
>> > arch/arm/boot/dts/imx6q-icore.dts | 59 ++++++++
>> > arch/arm/boot/dts/imx6qdl-icore.dtsi | 271 +++++++++++++++++++++++++++++++++++
>> > 4 files changed, 391 insertions(+)
>> > create mode 100644 arch/arm/boot/dts/imx6dl-icore.dts
>> > create mode 100644 arch/arm/boot/dts/imx6q-icore.dts
>> > create mode 100644 arch/arm/boot/dts/imx6qdl-icore.dtsi
>>
>> Can you pick this series?
>
> Sorry for the delay. The first two patches look good, and I had a
> couple of small comments on the other 3. Also, for the initial board
> support submission like this, you do not need to split it per device
> support. That said, please squash the series into one patch when
> resending.

Sent v8 by squash the usb host and otg with first patch and second and
third one keep separated as one is new board dts and other one though
it is FEC support it also have a rmii_clk addition which is kind of
new compared to other qdl dtsi files. So please let me know if have
any more comments.

thanks!
--
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.