Re: [PATCH v2] DAX: enable iostat for read/write

Kani, Toshimitsu
2016-10-17T17:45:14Z

On Mon, 2016-10-17 at 11:29 -0600, Ross Zwisler wrote:
> On Mon, Oct 17, 2016 at 11:18:58AM -0600, Toshi Kani wrote:
> >
> > DAX IO path does not support iostat, but its metadata IO path does.
> > Therefore, iostat shows metadata IO statistics only, which has been
> > confusing to users.
> >
> > Add iostat support to the DAX read/write path.
> >
> > Note, iostat still does not support the DAX mmap path as it allows
> > user applications to access directly.
> >
> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> > ---
> > v2:
> > - Set a minimum of one sector (Dan Williams)
>
> What about Dave's feedback that this code just reimplements
> generic_start_io_acct() and generic_end_io_acct()?

My bad. There was some issue in my email box and I just realized it.
Please disregard this version...

Thanks,
-Toshi