From: Ryan Swan <ryan@ryanswan.com>
To: devel@driverdev.osuosl.org
Cc: Ryan Swan <ryan@ryanswan.com>,
liodot@gmail.com, charrer@alacritech.com,
gregkh@linuxfoundation.org, LinoSanfilippo@gmx.de,
bmarsh94@gmail.com, amarjargal.gundjalam@gmail.com,
aquannie@gmail.com, janani.rvchndrn@gmail.com,
kevin.m.wern@gmail.com, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: slicoss: replace memcpy_fromio with memcpy
Date: Tue, 18 Oct 2016 17:26:43 -0400 [thread overview]
Message-ID: <1476826003-1202-1-git-send-email-ryan@ryanswan.com> (raw)
As per discusion with Lino Sanfilippo, memcpy is the proper way to copy
across dma memory, which also removes sparse warning that triggered
inquiry.
Signed-off-by: Ryan Swan <ryan@ryanswan.com>
---
drivers/staging/slicoss/slicoss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 2802b90..9a1dc72 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -1057,7 +1057,7 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr)
if (stats->rcv_drops > old->rcv_drops)
adapter->rcv_drops += (stats->rcv_drops -
old->rcv_drops);
- memcpy_fromio(old, stats, sizeof(*stats));
+ memcpy(old, stats, sizeof(*stats));
break;
}
case SLIC_UPR_RLSR:
--
2.7.4
next reply other threads:[~2016-10-18 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 21:26 Ryan Swan [this message]
2016-10-18 21:36 ` [PATCH] staging: slicoss: replace memcpy_fromio with memcpy Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476826003-1202-1-git-send-email-ryan@ryanswan.com \
--to=ryan@ryanswan.com \
--cc=LinoSanfilippo@gmx.de \
--cc=amarjargal.gundjalam@gmail.com \
--cc=aquannie@gmail.com \
--cc=bmarsh94@gmail.com \
--cc=charrer@alacritech.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=janani.rvchndrn@gmail.com \
--cc=kevin.m.wern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox