* [PATCH] staging: slicoss: replace memcpy_fromio with memcpy
@ 2016-10-18 21:26 Ryan Swan
2016-10-18 21:36 ` Lino Sanfilippo
0 siblings, 1 reply; 2+ messages in thread
From: Ryan Swan @ 2016-10-18 21:26 UTC (permalink / raw)
To: devel
Cc: Ryan Swan, liodot, charrer, gregkh, LinoSanfilippo, bmarsh94,
amarjargal.gundjalam, aquannie, janani.rvchndrn, kevin.m.wern,
linux-kernel
As per discusion with Lino Sanfilippo, memcpy is the proper way to copy
across dma memory, which also removes sparse warning that triggered
inquiry.
Signed-off-by: Ryan Swan <ryan@ryanswan.com>
---
drivers/staging/slicoss/slicoss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 2802b90..9a1dc72 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -1057,7 +1057,7 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr)
if (stats->rcv_drops > old->rcv_drops)
adapter->rcv_drops += (stats->rcv_drops -
old->rcv_drops);
- memcpy_fromio(old, stats, sizeof(*stats));
+ memcpy(old, stats, sizeof(*stats));
break;
}
case SLIC_UPR_RLSR:
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: slicoss: replace memcpy_fromio with memcpy
2016-10-18 21:26 [PATCH] staging: slicoss: replace memcpy_fromio with memcpy Ryan Swan
@ 2016-10-18 21:36 ` Lino Sanfilippo
0 siblings, 0 replies; 2+ messages in thread
From: Lino Sanfilippo @ 2016-10-18 21:36 UTC (permalink / raw)
To: Ryan Swan, devel
Cc: liodot, charrer, gregkh, bmarsh94, amarjargal.gundjalam, aquannie,
janani.rvchndrn, kevin.m.wern, linux-kernel
On 18.10.2016 23:26, Ryan Swan wrote:
> As per discusion with Lino Sanfilippo, memcpy is the proper way to copy
> across dma memory, which also removes sparse warning that triggered
> inquiry.
>
> Signed-off-by: Ryan Swan <ryan@ryanswan.com>
> ---
> drivers/staging/slicoss/slicoss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 2802b90..9a1dc72 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -1057,7 +1057,7 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr)
> if (stats->rcv_drops > old->rcv_drops)
> adapter->rcv_drops += (stats->rcv_drops -
> old->rcv_drops);
> - memcpy_fromio(old, stats, sizeof(*stats));
> + memcpy(old, stats, sizeof(*stats));
> break;
> }
> case SLIC_UPR_RLSR:
>
Reviewed-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-18 21:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 21:26 [PATCH] staging: slicoss: replace memcpy_fromio with memcpy Ryan Swan
2016-10-18 21:36 ` Lino Sanfilippo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox