Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

Andi Kleen
2016-10-20T16:49:22Z

On Thu, Oct 20, 2016 at 11:41:11AM -0500, Nilay Vaish wrote:
> On 19 October 2016 at 17:01, Jin Yao <yao.jin@linux.intel.com> wrote:
> > diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
> > index 40ecf25..4f6bf6c 100644
> > --- a/tools/perf/util/callchain.h
> > +++ b/tools/perf/util/callchain.h
> > @@ -115,6 +115,10 @@ struct callchain_list {
> > bool unfolded;
> > bool has_children;
> > };
> > + u64 branch_count;
> > + u64 predicted_count;
> > + u64 abort_count;
>
> Can you explain what abort count is? It seems you are referring to
> miss-speculated branches. If that is the case, I would prefer that we
> replace abort by miss_speculated or miss_predicted.

abort refers to TSX aborts. It has nothing to do with branch
mispredictions.

-Andi