Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex

Binoy Jayan
2016-10-24T10:09:33Z

On 20 October 2016 at 14:40, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote:
>> - sema_init(&ctrl_info->sync_request_sem,
>> - PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS);
>> + mutex_init(&ctrl_info->sync_request_mutex);
>>
>
> Looking at this again, I see that PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS
> is '3', so this is in fact a counting semaphore rather than a mutex,
> and the conversion is changing the behavior.
>
> The patch can't go in unless you either show that it should be
> a normal mutex rather than a counting semaphore, or you find a way
> to keep the behavior the same.

This still holds true, will try changing this accordingly.

-Binoy