Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex

Arnd Bergmann
2016-10-20T09:10:58Z

On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote:
> - sema_init(&ctrl_info->sync_request_sem,
> - PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS);
> + mutex_init(&ctrl_info->sync_request_mutex);
>

Looking at this again, I see that PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS
is '3', so this is in fact a counting semaphore rather than a mutex,
and the conversion is changing the behavior.

The patch can't go in unless you either show that it should be
a normal mutex rather than a counting semaphore, or you find a way
to keep the behavior the same.

Arnd