From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755180AbcJTLsv (ORCPT <rfc822;w@1wt.eu>);
        Thu, 20 Oct 2016 07:48:51 -0400
Received: from mga03.intel.com ([134.134.136.65]:52086 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753495AbcJTLsu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Oct 2016 07:48:50 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,518,1473145200"; 
   d="scan'208";a="892021613"
Message-ID: <1476963946.3693.21.camel@linux.intel.com>
Subject: Re: [PATCH v1 1/1] mfd: intel_soc_pmic_core: Use explicit name of
 GPIO controller
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>
Date: Thu, 20 Oct 2016 14:45:46 +0300
In-Reply-To: <20161020111323.GP4329@intel.com>
References: <20161020093613.45939-1-andriy.shevchenko@linux.intel.com>
         <20161020111323.GP4329@intel.com>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2016-10-20 at 14:13 +0300, Ville Syrjälä wrote:
> On Thu, Oct 20, 2016 at 12:36:13PM +0300, Andy Shevchenko wrote:
> > The Crystal Cove GPIO driver has its explicit name, i.e.
> > crystal_cove_gpio.
> > 
> > Use it explicitly to be in align with the rest of code, pretty
> > grepping, and
> > prevent potential breakage if GPIO driver file name ever changed.
> > 
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/mfd/intel_soc_pmic_core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mfd/intel_soc_pmic_core.c
> > b/drivers/mfd/intel_soc_pmic_core.c
> > index 12d6ebb4..7fd8e87 100644
> > --- a/drivers/mfd/intel_soc_pmic_core.c
> > +++ b/drivers/mfd/intel_soc_pmic_core.c
> > @@ -34,7 +34,7 @@ static struct gpiod_lookup_table panel_gpio_table
> > = {
> >  	.dev_id = "0000:00:02.0",
> >  	.table = {
> >  		/* Panel EN/DISABLE */
> > -		GPIO_LOOKUP("gpio_crystalcove", 94, "panel",
> > GPIO_ACTIVE_HIGH),
> > +		GPIO_LOOKUP("crystal_cove_gpio", 94, "panel",
> > GPIO_ACTIVE_HIGH),
> 
> This looks like it would break things.

Yeah. Good catch.

>  The gpio_chip->label which is
> used for the lookup is based on KBUILD_MODNAME and the moduled is
> called gpio-crystalcove.

...which I think is wrong. Only few drivers are binding to file / module
name.

Perhaps it should be fixed all together.

Naming a bit chaotic in drivers/gpio/*::chip.label, though majority of
them are using dev_name() of actual device.

Linus, what is your opinion?


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy