From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S938895AbcJXNPc (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Oct 2016 09:15:32 -0400
Received: from mga14.intel.com ([192.55.52.115]:39284 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S934917AbcJXNPb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Oct 2016 09:15:31 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,542,1473145200"; 
   d="scan'208";a="776877401"
From: "Luc, Piotr" <Piotr.Luc@intel.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "dougthompson@xmission.com" <dougthompson@xmission.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
        "srinivas.pandruvada@linux.intel.com" 
        <srinivas.pandruvada@linux.intel.com>,
        "bp@alien8.de" <bp@alien8.de>, "lenb@kernel.org" <lenb@kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family
 processor macros
Thread-Topic: [PATCH v2 02/11] tools/power turbostat: Use Intel family
 processor macros
Thread-Index: AQHSJhJkSmCHiOU1W0GNQ+KoqgOUH6C3kv8A
Date: Mon, 24 Oct 2016 13:15:25 +0000
Message-ID: <1477314612.3927.11.camel@intel.com>
References: <20161013153105.2517-1-piotr.luc@intel.com>
         <20161013153105.2517-3-piotr.luc@intel.com>
         <alpine.DEB.2.20.1610141354090.11707@nanos>
In-Reply-To: <alpine.DEB.2.20.1610141354090.11707@nanos>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.237.138.164]
Content-Type: text/plain; charset="utf-8"
Content-ID: <122E96FB6E44374B9AF6CCCAE444F45B@intel.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9ODFbja014259

On Fri, 2016-10-14 at 13:56 +0200, Thomas Gleixner wrote:
> On Thu, 13 Oct 2016, Piotr Luc wrote:

> > 
> > +	case INTEL_FAM6_SANDYBRIDGE:		/* SNB */
> 
> Especialy those, which are completely useless?
> 
> The defines are there to be self explaining and the extra verbose
> information should be in the header file defining the macros and not
> in the
> source code.

Hi

I submitted the turbostat patchset 
https://lkml.kernel.org/r/20161018210652.29365-1-piotr.luc@intel.com to
address the issues.

Regards
Piotr