From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754000AbcJYEOI (ORCPT ); Tue, 25 Oct 2016 00:14:08 -0400 Received: from smtprelay0128.hostedemail.com ([216.40.44.128]:59039 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750933AbcJYEOG (ORCPT ); Tue, 25 Oct 2016 00:14:06 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:4321:5007:10004:10400:10848:11026:11658:11914:12296:12438:12740:12760:13069:13311:13357:13439:14659:14721:21080:30054:30060:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: ants33_788eaf3971b63 X-Filterd-Recvd-Size: 2409 Message-ID: <1477368827.1998.1.camel@perches.com> Subject: Re: linux.git: printk() problem From: Joe Perches To: Sergey Senozhatsky , Linus Torvalds Cc: Sergey Senozhatsky , Geert Uytterhoeven , Tetsuo Handa , Linux Kernel Mailing List , Petr Mladek , Tejun Heo , Calvin Owens , Steven Rostedt , Andrew Morton Date: Mon, 24 Oct 2016 21:13:47 -0700 In-Reply-To: <20161025040617.GA565@swordfish> References: <1477249607.3561.2.camel@perches.com> <20161024140845.GA626@swordfish> <20161025015554.GA495@swordfish> <20161025040617.GA565@swordfish> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-10-25 at 13:06 +0900, Sergey Senozhatsky wrote: > so how about skipping mod_timer in deferred_cont_flush() and just > cont_flush() when we are in oops? here is probably one more thing we > need to "fix" first. oops_in_progress is unreliable. x86 oops_end() > does bust_spinlocks(0) before it calls panic(). panic() increments > oops_in_progress but decrements it back to 0 (bust_spinlocks(0)) before > it does console_flush_on_panic(). so there is (almost) no way > console_flush_on_panic() can see oops_in_progress != 0. I think Linus' insistence on not requiring EOL/newline is misguided. It'd be simpler to avoid the flushes and have a require EOL/newline.