From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758992AbcJYSFP (ORCPT ); Tue, 25 Oct 2016 14:05:15 -0400 Received: from smtprelay0241.hostedemail.com ([216.40.44.241]:52254 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756708AbcJYSFO (ORCPT ); Tue, 25 Oct 2016 14:05:14 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6119:6691:7903:10004:10400:10848:11026:11232:11658:11914:12050:12296:12663:12740:12760:13069:13311:13357:13439:14181:14659:14721:21080:21324:21433:21451:30054:30060:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: scarf04_676b01babf563 X-Filterd-Recvd-Size: 1913 Message-ID: <1477418709.1998.12.camel@perches.com> Subject: Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT From: Joe Perches To: Linus Torvalds , Mark Rutland Cc: Linux Kernel Mailing List , Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" Date: Tue, 25 Oct 2016 11:05:09 -0700 In-Reply-To: References: <4cbf196b83cd9d175634e7056744dc649ae87f63.1477253239.git.joe@perches.com> <20161024113131.GH15620@leverpostej> <1477326477.1984.2.camel@perches.com> <20161024164255.GN15620@leverpostej> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-10-25 at 10:55 -0700, Linus Torvalds wrote: > And yes, what we probably *should* do is to do the newline breaking > when adding things to the log, rather than doing it in the > "msg_print_text()" phase. Yeah. One thing that'd be nice one day is to remove all the #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt lines and have printk do that instead using a singleton or a lookup for KBUILD_MODNAME as appropriate. > There's a reason why I actually would have liked to entirely rewrite > the whole printk mess.But there's also a reason I didn't - I'm not > quite _that_ much of a glutton for punishment. You sure?