From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934350AbcJZTjD (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Oct 2016 15:39:03 -0400
Received: from mga04.intel.com ([192.55.52.120]:42553 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933896AbcJZTjA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Oct 2016 15:39:00 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,551,1473145200"; 
   d="scan'208";a="24396428"
Message-ID: <1477510733.2680.32.camel@linux.intel.com>
Subject: Re: [PATCH v6 5/9] x86/sysctl: Add sysctl for ITMT scheduling
 feature
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: rjw@rjwysocki.net, mingo@redhat.com, bp@suse.de, x86@kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-acpi@vger.kernel.org, peterz@infradead.org, jolsa@redhat.com,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date: Wed, 26 Oct 2016 12:38:53 -0700
In-Reply-To: <alpine.DEB.2.20.1610262010420.5013@nanos>
References: <cover.1477000078.git.tim.c.chen@linux.intel.com>
          <b3f648c2c4cd36b6a043239bee8437a2060c0ac4.1477000078.git.tim.c.chen@linux.intel.com>
          <alpine.DEB.2.20.1610261251550.4983@nanos>
         <1477505006.2680.25.camel@linux.intel.com>
         <alpine.DEB.2.20.1610262010420.5013@nanos>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-10-26 at 20:11 +0200, Thomas Gleixner wrote:
> On Wed, 26 Oct 2016, Tim Chen wrote:
> 
> > 
> > On Wed, 2016-10-26 at 12:52 +0200, Thomas Gleixner wrote:
> > > 
> > > On Thu, 20 Oct 2016, Tim Chen wrote:
> > > > 
> > > > 
> > > >  
> > > > +	if (itmt_sysctl_header)
> > > > +		unregister_sysctl_table(itmt_sysctl_header);
> > > What sets itmt_sysctl_header to NULL?
> > > 
> > If the registration of the itmt sysctl table has failed, it will
> > be NULL.
> And what clears it _AFTER_ the deregistration? Nothing, AFAICT.

Ok. I'll clear itmt_sysctl_header here.

Thanks.

Tim