From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965099AbcJ0SWn (ORCPT ); Thu, 27 Oct 2016 14:22:43 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36490 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941644AbcJ0SWl (ORCPT ); Thu, 27 Oct 2016 14:22:41 -0400 From: Bhumika Goyal To: ccaulfie@redhat.com, teigland@redhat.com, cluster-devel@redhat.com, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Cc: Bhumika Goyal Subject: [PATCH] fs: dlm: lockspace: constify kset_uevent_ops structures Date: Thu, 27 Oct 2016 23:51:14 +0530 Message-Id: <1477592474-18513-1-git-send-email-bhumirks@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Declare kset_uevent_ops structure as const as it is only passed as the second argument to the function kset_create_and_add. This argument is of type const struct kset_uevent_ops *, so kset_uevent_ops structures having this property can be declared const. Done using Coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct kset_uevent_ops i@p = {...}; @ok1@ identifier r1.i; position p; expression e1,e2; @@ kset_create_and_add(e1,&i@p,e2) @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ static +const struct kset_uevent_ops i={...}; @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct kset_uevent_ops i; File size before: text data bss dec hex filename 8034 528 484 9046 2356 fs/dlm/lockspace.o File size after: text data bss dec hex filename 8050 496 484 9030 2346 fs/dlm/lockspace.o Signed-off-by: Bhumika Goyal --- fs/dlm/lockspace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c index f3e7278..2ea1b77 100644 --- a/fs/dlm/lockspace.c +++ b/fs/dlm/lockspace.c @@ -233,7 +233,7 @@ static int dlm_uevent(struct kset *kset, struct kobject *kobj, return 0; } -static struct kset_uevent_ops dlm_uevent_ops = { +static const struct kset_uevent_ops dlm_uevent_ops = { .uevent = dlm_uevent, }; -- 1.9.1