From: Brian Norris <computersforpeace@gmail.com>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: <linux-kernel@vger.kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
SF Markus Elfring <elfring@users.sourceforge.net>
Subject: [PATCH v2] checkpatch: fix uninitialized var when run with --no-tree
Date: Fri, 28 Oct 2016 19:44:32 -0700 [thread overview]
Message-ID: <1477709072-94668-1-git-send-email-computersforpeace@gmail.com> (raw)
If checkpatch.pl gets copied out of the tree, --no-tree shouldn't start
complaining:
Use of uninitialized value $root in concatenation (.) or string at
/path/to/checkpatch.pl line 764.
Let's just give the safe answer instead -- don't warn about "obsolete"
files.
Fixes: 85b0ee18bbf8 ("checkpatch: see if modified files are marked obsolete in MAINTAINERS")
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
v2: change condition to check for $root, not $tree
scripts/checkpatch.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a8368d1c4348..c9cbfed326a7 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -761,6 +761,8 @@ sub seed_camelcase_file {
sub is_maintained_obsolete {
my ($filename) = @_;
+ return 0 if (!defined $root);
+
return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
--
2.8.0.rc3.226.g39d4020
reply other threads:[~2016-10-29 2:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477709072-94668-1-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=elfring@users.sourceforge.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox