From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1168184AbcKAJHc (ORCPT ); Tue, 1 Nov 2016 05:07:32 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:40342 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1168159AbcKAJH3 (ORCPT ); Tue, 1 Nov 2016 05:07:29 -0400 Message-ID: <1477991244.2475.26.camel@pengutronix.de> Subject: Re: [PATCH] drm/imx: Fix error handling From: Philipp Zabel To: Christophe JAILLET Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Dan Carpenter Date: Tue, 01 Nov 2016 10:07:24 +0100 In-Reply-To: <20161031175917.4053-1-christophe.jaillet@wanadoo.fr> References: <20161031175917.4053-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe, Am Montag, den 31.10.2016, 18:59 +0100 schrieb Christophe JAILLET: > 'drm_dev_alloc()' returns an error pointer in case of error, not NULL > So test it with IS_ERR. > > This behavior has been introduced recently in 0f2886057be3. For some > reason, this file has not been updated. > > Fixes: 0f2886057be3 ("drm: Don't swallow error codes in drm_dev_alloc()") > > Signed-off-by: Christophe JAILLET > --- > drivers/gpu/drm/imx/imx-drm-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > index 98df09c2b388..3acc976cc04e 100644 > --- a/drivers/gpu/drm/imx/imx-drm-core.c > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > @@ -357,8 +357,8 @@ static int imx_drm_bind(struct device *dev) > int ret; > > drm = drm_dev_alloc(&imx_drm_driver, dev); > - if (!drm) > - return -ENOMEM; > + if (IS_ERR(drm)) > + return PTR_ERR(drm); > > imxdrm = devm_kzalloc(dev, sizeof(*imxdrm), GFP_KERNEL); > if (!imxdrm) { Thank you for the patch. The same fix is in the queue already: 8cca354816ad ("drm/imx: drm_dev_alloc() returns error pointers"). Only Dan selected commit 54db5decce17 ("drm/imx: drop deprecated load/unload drm_driver ops") as the culprit. regards Philipp