From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1168708AbcKAKq4 (ORCPT ); Tue, 1 Nov 2016 06:46:56 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:34825 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1168654AbcKAKqw (ORCPT ); Tue, 1 Nov 2016 06:46:52 -0400 From: Johan Hovold To: Thierry Reding Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH] pwm: fix device reference leak Date: Tue, 1 Nov 2016 11:46:39 +0100 Message-Id: <1477997199-29305-1-git-send-email-johan@kernel.org> X-Mailer: git-send-email 2.7.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make sure to drop the reference to the parent device taken by class_find_device() after "unexporting" any children when deregistering a pwm chip. Fixes: 0733424c9ba9 ("pwm: Unexport children before chip removal") Signed-off-by: Johan Hovold --- drivers/pwm/sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c index 0296d8178ae2..a813239300c3 100644 --- a/drivers/pwm/sysfs.c +++ b/drivers/pwm/sysfs.c @@ -425,6 +425,8 @@ void pwmchip_sysfs_unexport_children(struct pwm_chip *chip) if (test_bit(PWMF_EXPORTED, &pwm->flags)) pwm_unexport_child(parent, pwm); } + + put_device(parent); } static int __init pwm_sysfs_init(void) -- 2.7.3