From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752796AbcKHONS (ORCPT <rfc822;w@1wt.eu>);
        Tue, 8 Nov 2016 09:13:18 -0500
Received: from mx2.suse.de ([195.135.220.15]:44986 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752595AbcKHONP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 8 Nov 2016 09:13:15 -0500
Message-ID: <1478614393.2168.2.camel@suse.com>
Subject: Re: [PATCH] USB: serial: fix invalid user-pointer checks
From: Oliver Neukum <oneukum@suse.com>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Tue, 08 Nov 2016 15:13:13 +0100
In-Reply-To: <1478608010-23588-1-git-send-email-johan@kernel.org>
References: <1478608010-23588-1-git-send-email-johan@kernel.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-11-08 at 13:26 +0100, Johan Hovold wrote:
> Drop invalid user-pointer checks from ioctl handlers.
> 
> A NULL-pointer can be valid in user space and copy_to_user() takes
> care
> of sanity checking.

Shouldn't we bail out early in these cases?

	Regards
		Oliver