From: Kees Cook <keescook@chromium.org>
To: Joel Fernandes <joelaf@google.com>
Cc: Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 2/8] pstore: Warn on PSTORE_TYPE_PMSG using deprecated function
Date: Fri, 11 Nov 2016 14:21:47 -0800 [thread overview]
Message-ID: <1478902913-143778-3-git-send-email-keescook@chromium.org> (raw)
In-Reply-To: <1478902913-143778-1-git-send-email-keescook@chromium.org>
From: Joel Fernandes <joelaf@google.com>
PMSG now uses ramoops_pstore_write_buf_user() instead of ...write_buf().
Print a ratelimited warning if gets accidentally called.
Signed-off-by: Joel Fernandes <joelaf@google.com>
[kees: adjusted commit log and added -EINVAL return]
Signed-off-by: Kees Cook <keescook@chromium.org>
---
fs/pstore/ram.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 6ad831b9d1b8..6d1393965b0a 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -288,10 +288,8 @@ static int notrace ramoops_pstore_write_buf(enum pstore_type_id type,
persistent_ram_write(cxt->fprz, buf, size);
return 0;
} else if (type == PSTORE_TYPE_PMSG) {
- if (!cxt->mprz)
- return -ENOMEM;
- persistent_ram_write(cxt->mprz, buf, size);
- return 0;
+ pr_warn_ratelimited("PMSG shouldn't call %s\n", __func__);
+ return -EINVAL;
}
if (type != PSTORE_TYPE_DMESG)
--
2.7.4
next prev parent reply other threads:[~2016-11-11 22:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 22:21 [PATCH v3 0/8] pstore: Improve performance of ftrace backend with ramoops Kees Cook
2016-11-11 22:21 ` [PATCH v3 1/8] pstore: Make spinlock per zone instead of global Kees Cook
2016-11-11 22:21 ` Kees Cook [this message]
2016-11-11 22:21 ` [PATCH v3 3/8] pstore: Allow prz to control need for locking Kees Cook
2016-11-11 22:21 ` [PATCH v3 4/8] pstore: Make ramoops_init_przs generic for other prz arrays Kees Cook
2016-11-11 22:21 ` [PATCH v3 5/8] ramoops: Split ftrace buffer space into per-CPU zones Kees Cook
2016-11-11 22:21 ` [PATCH v3 6/8] pstore: Add ftrace timestamp counter Kees Cook
2016-11-11 22:21 ` [PATCH v3 7/8] pstore: Merge per-CPU ftrace records into one Kees Cook
2016-11-11 22:21 ` [PATCH v3 8/8] pstore: improve error report for failed setup Kees Cook
2016-11-15 19:55 ` [PATCH v3 0/8] pstore: Improve performance of ftrace backend with ramoops Joel Fernandes
2016-11-15 21:36 ` Kees Cook
2016-11-15 22:06 ` Joel Fernandes
2016-11-15 22:14 ` Kees Cook
2016-11-16 6:38 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478902913-143778-3-git-send-email-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).