* [PATCH] drm/radeon: use list_move in radeon_vm_bo_update
@ 2016-11-11 12:26 Geliang Tang
2016-11-11 12:26 ` [PATCH] HID: intel_ish-hid: use list_move_tail in ishtp_cl_read_start Geliang Tang
2016-11-11 13:46 ` [PATCH] drm/radeon: use list_move in radeon_vm_bo_update Christian König
0 siblings, 2 replies; 4+ messages in thread
From: Geliang Tang @ 2016-11-11 12:26 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie
Cc: Geliang Tang, dri-devel, linux-kernel
Use list_move() instead of list_del() + list_add() to simplify the code.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
drivers/gpu/drm/radeon/radeon_vm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
index a135874..2f1e372 100644
--- a/drivers/gpu/drm/radeon/radeon_vm.c
+++ b/drivers/gpu/drm/radeon/radeon_vm.c
@@ -933,8 +933,7 @@ int radeon_vm_bo_update(struct radeon_device *rdev,
}
list_del_init(&bo_va->vm_status);
} else {
- list_del(&bo_va->vm_status);
- list_add(&bo_va->vm_status, &vm->cleared);
+ list_move(&bo_va->vm_status, &vm->cleared);
}
spin_unlock(&vm->status_lock);
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] HID: intel_ish-hid: use list_move_tail in ishtp_cl_read_start
2016-11-11 12:26 [PATCH] drm/radeon: use list_move in radeon_vm_bo_update Geliang Tang
@ 2016-11-11 12:26 ` Geliang Tang
2016-11-11 22:51 ` Srinivas Pandruvada
2016-11-11 13:46 ` [PATCH] drm/radeon: use list_move in radeon_vm_bo_update Christian König
1 sibling, 1 reply; 4+ messages in thread
From: Geliang Tang @ 2016-11-11 12:26 UTC (permalink / raw)
To: Srinivas Pandruvada, Jiri Kosina, Benjamin Tissoires
Cc: Geliang Tang, linux-input, linux-kernel
Use list_move() instead of list_del() + list_add_tail() to simplify
the code.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
drivers/hid/intel-ish-hid/ishtp/client.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c
index aad6132..0979e04 100644
--- a/drivers/hid/intel-ish-hid/ishtp/client.c
+++ b/drivers/hid/intel-ish-hid/ishtp/client.c
@@ -497,12 +497,8 @@ int ishtp_cl_read_start(struct ishtp_cl *cl)
out:
/* if ishtp_hbm_cl_flow_control_req failed, return rb to free list */
if (rets && rb) {
- spin_lock_irqsave(&dev->read_list_spinlock, dev_flags);
- list_del(&rb->list);
- spin_unlock_irqrestore(&dev->read_list_spinlock, dev_flags);
-
spin_lock_irqsave(&cl->free_list_spinlock, flags);
- list_add_tail(&rb->list, &cl->free_rb_list.list);
+ list_move_tail(&rb->list, &cl->free_rb_list.list);
spin_unlock_irqrestore(&cl->free_list_spinlock, flags);
}
return rets;
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] HID: intel_ish-hid: use list_move_tail in ishtp_cl_read_start
2016-11-11 12:26 ` [PATCH] HID: intel_ish-hid: use list_move_tail in ishtp_cl_read_start Geliang Tang
@ 2016-11-11 22:51 ` Srinivas Pandruvada
0 siblings, 0 replies; 4+ messages in thread
From: Srinivas Pandruvada @ 2016-11-11 22:51 UTC (permalink / raw)
To: Geliang Tang, Jiri Kosina, Benjamin Tissoires; +Cc: linux-input, linux-kernel
On Fri, 2016-11-11 at 20:26 +0800, Geliang Tang wrote:
> Use list_move() instead of list_del() + list_add_tail() to simplify
> the code.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> drivers/hid/intel-ish-hid/ishtp/client.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c
> b/drivers/hid/intel-ish-hid/ishtp/client.c
> index aad6132..0979e04 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/client.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/client.c
> @@ -497,12 +497,8 @@ int ishtp_cl_read_start(struct ishtp_cl *cl)
> out:
> /* if ishtp_hbm_cl_flow_control_req failed, return rb to
> free list */
> if (rets && rb) {
> - spin_lock_irqsave(&dev->read_list_spinlock,
> dev_flags);
> - list_del(&rb->list);
> - spin_unlock_irqrestore(&dev->read_list_spinlock,
> dev_flags);
> -
> spin_lock_irqsave(&cl->free_list_spinlock, flags);
> - list_add_tail(&rb->list, &cl->free_rb_list.list);
> + list_move_tail(&rb->list, &cl->free_rb_list.list);
Logically the result is not same. They were protected under two
spinlocks, now they are not.
Thanks,
Srinivas
> spin_unlock_irqrestore(&cl->free_list_spinlock,
> flags);
> }
> return rets;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/radeon: use list_move in radeon_vm_bo_update
2016-11-11 12:26 [PATCH] drm/radeon: use list_move in radeon_vm_bo_update Geliang Tang
2016-11-11 12:26 ` [PATCH] HID: intel_ish-hid: use list_move_tail in ishtp_cl_read_start Geliang Tang
@ 2016-11-11 13:46 ` Christian König
1 sibling, 0 replies; 4+ messages in thread
From: Christian König @ 2016-11-11 13:46 UTC (permalink / raw)
To: Geliang Tang, Alex Deucher, David Airlie; +Cc: dri-devel, linux-kernel
Am 11.11.2016 um 13:26 schrieb Geliang Tang:
> Use list_move() instead of list_del() + list_add() to simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>.
> ---
> drivers/gpu/drm/radeon/radeon_vm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
> index a135874..2f1e372 100644
> --- a/drivers/gpu/drm/radeon/radeon_vm.c
> +++ b/drivers/gpu/drm/radeon/radeon_vm.c
> @@ -933,8 +933,7 @@ int radeon_vm_bo_update(struct radeon_device *rdev,
> }
> list_del_init(&bo_va->vm_status);
> } else {
> - list_del(&bo_va->vm_status);
> - list_add(&bo_va->vm_status, &vm->cleared);
> + list_move(&bo_va->vm_status, &vm->cleared);
> }
> spin_unlock(&vm->status_lock);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-11 22:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-11 12:26 [PATCH] drm/radeon: use list_move in radeon_vm_bo_update Geliang Tang
2016-11-11 12:26 ` [PATCH] HID: intel_ish-hid: use list_move_tail in ishtp_cl_read_start Geliang Tang
2016-11-11 22:51 ` Srinivas Pandruvada
2016-11-11 13:46 ` [PATCH] drm/radeon: use list_move in radeon_vm_bo_update Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).