From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Mathias Nyman <mathias.nyman@intel.com>
Cc: linux-rpi-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: xhci: Enable LPM for VIA LABS VL805
Date: Tue, 11 Feb 2020 11:34:59 +0200 [thread overview]
Message-ID: <1478f170-f0ec-96df-79cf-f7c44bebc290@linux.intel.com> (raw)
In-Reply-To: <20200210185921.GA1058087@kroah.com>
On 10.2.2020 20.59, Greg Kroah-Hartman wrote:
> On Mon, Jan 20, 2020 at 03:24:22PM +0100, Nicolas Saenz Julienne wrote:
>> This PCIe controller chip is used on the Raspberry Pi 4 and multiple
>> adapter cards. There is no publicly available documentation for the
>> chip, yet both the downstream RPi4 kernel and the controller cards
>> support/advertise LPM support.
>>
>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>> ---
>> drivers/usb/host/xhci-pci.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
>> index 4917c5b033fa..c1976e98992b 100644
>> --- a/drivers/usb/host/xhci-pci.c
>> +++ b/drivers/usb/host/xhci-pci.c
>> @@ -241,6 +241,9 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>> pdev->device == 0x3432)
>> xhci->quirks |= XHCI_BROKEN_STREAMS;
>>
>> + if (pdev->vendor == PCI_VENDOR_ID_VIA && pdev->device == 0x3483)
>> + xhci->quirks |= XHCI_LPM_SUPPORT;
>> +
>> if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
>> pdev->device == 0x1042)
>> xhci->quirks |= XHCI_BROKEN_STREAMS;
>
> Mathias, is this in your review queue?
>
Ah yes, before adding link power management support for this controller we
should check that it has sane (or any) exit latency values set in its
HCSPARAMS3 capability register.
Nicolas, if you have this controller could you show the capability registers:
cat /sys/kernel/debug/usb/xhci/*/reg-cap
-Mathias
next prev parent reply other threads:[~2020-02-11 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 14:24 [PATCH] usb: xhci: Enable LPM for VIA LABS VL805 Nicolas Saenz Julienne
2020-02-10 18:59 ` Greg Kroah-Hartman
2020-02-11 9:34 ` Mathias Nyman [this message]
2020-02-11 9:49 ` Stefan Wahren
2020-02-11 10:02 ` Nicolas Saenz Julienne
2020-02-11 12:13 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478f170-f0ec-96df-79cf-f7c44bebc290@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=nsaenzjulienne@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox