From: Alexandre Bailon <abailon@baylibre.com>
To: david@lechnology.com, b-liu@ti.com, balbi@kernel.org
Cc: khilman@baylibre.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, nsekhar@ti.com,
Alexandre Bailon <abailon@baylibre.com>
Subject: [PATCH v6 1/2] usb: musb: da8xx: Call earlier clk_prepare_enable()
Date: Tue, 15 Nov 2016 18:42:46 +0100 [thread overview]
Message-ID: <1479231767-2434-2-git-send-email-abailon@baylibre.com> (raw)
In-Reply-To: <1479231767-2434-1-git-send-email-abailon@baylibre.com>
The first attempt to read a register may fail because the clock may not
be enabled, and then the probe of musb driver will fail.
Call clk_prepare_enable() before the first register read.
Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
---
drivers/usb/musb/da8xx.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index 2440f88..4fc226c 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -366,6 +366,12 @@ static int da8xx_musb_init(struct musb *musb)
musb->mregs += DA8XX_MENTOR_CORE_OFFSET;
+ ret = clk_prepare_enable(glue->clk);
+ if (ret) {
+ dev_err(glue->dev, "failed to enable clock\n");
+ return ret;
+ }
+
/* Returns zero if e.g. not clocked */
rev = musb_readl(reg_base, DA8XX_USB_REVISION_REG);
if (!rev)
@@ -377,12 +383,6 @@ static int da8xx_musb_init(struct musb *musb)
goto fail;
}
- ret = clk_prepare_enable(glue->clk);
- if (ret) {
- dev_err(glue->dev, "failed to enable clock\n");
- goto fail;
- }
-
setup_timer(&otg_workaround, otg_timer, (unsigned long)musb);
/* Reset the controller */
@@ -392,7 +392,7 @@ static int da8xx_musb_init(struct musb *musb)
ret = phy_init(glue->phy);
if (ret) {
dev_err(glue->dev, "Failed to init phy.\n");
- goto err_phy_init;
+ goto fail;
}
ret = phy_power_on(glue->phy);
@@ -412,9 +412,8 @@ static int da8xx_musb_init(struct musb *musb)
err_phy_power_on:
phy_exit(glue->phy);
-err_phy_init:
- clk_disable_unprepare(glue->clk);
fail:
+ clk_disable_unprepare(glue->clk);
return ret;
}
--
2.7.3
next prev parent reply other threads:[~2016-11-15 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 17:42 [PATCH v6 0/2] usb: musb: da8xx: Fix few issues Alexandre Bailon
2016-11-15 17:42 ` Alexandre Bailon [this message]
2016-11-15 17:42 ` [PATCH v6 2/2] usb: musb: da8xx: Set phy in OTG mode by default Alexandre Bailon
2016-11-18 18:11 ` [PATCH v6 0/2] usb: musb: da8xx: Fix few issues Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479231767-2434-2-git-send-email-abailon@baylibre.com \
--to=abailon@baylibre.com \
--cc=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=david@lechnology.com \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox