From: Joe Perches <joe@perches.com>
To: Tomas Winkler <tomas.winkler@intel.com>,
Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: don't check c99 types like uint8_t under tools
Date: Wed, 16 Nov 2016 06:34:21 -0800 [thread overview]
Message-ID: <1479306861.17487.0.camel@perches.com> (raw)
In-Reply-To: <1479286379-853-1-git-send-email-tomas.winkler@intel.com>
On Wed, 2016-11-16 at 10:52 +0200, Tomas Winkler wrote:
> Tools contains user space code so uintX_t types are just fine.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1c4348..42c3221be6eb 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5548,8 +5548,9 @@ sub process {
> "Using weak declarations can have unintended link defects\n" . $herecurr);
> }
>
> -# check for c99 types like uint8_t used outside of uapi/
> +# check for c99 types like uint8_t used outside of uapi/ and tools/
> if ($realfile !~ m@\binclude/uapi/@ &&
> + $realfile !~ m@\btools/@ &&
> $line =~ /\b($Declare)\s*$Ident\s*[=;,\[]/) {
> my $type = $1;
> if ($type =~ /\b($typeC99Typedefs)\b/) {
Makes sense, thanks.
Acked-by: Joe Perches <joe@perches.com>
prev parent reply other threads:[~2016-11-16 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 8:52 [PATCH] checkpatch: don't check c99 types like uint8_t under tools Tomas Winkler
2016-11-16 14:34 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479306861.17487.0.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox