From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753930AbcKQTbf (ORCPT <rfc822;w@1wt.eu>);
        Thu, 17 Nov 2016 14:31:35 -0500
Received: from mga05.intel.com ([192.55.52.43]:55923 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751161AbcKQTbd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 17 Nov 2016 14:31:33 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,655,1473145200"; 
   d="scan'208";a="32585959"
Message-ID: <1479411092.6544.129.camel@linux.intel.com>
Subject: Re: [RFC][PATCH] cpufreq: intel_pstate: Support of energy
 performance hint using HWP
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@rjwysocki.net, morten.rasmussen@arm.com, Juri.Lelli@arm.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Thu, 17 Nov 2016 11:31:32 -0800
In-Reply-To: <20161117064954.GD4894@vireshk-i7>
References: <1479250783-74336-1-git-send-email-srinivas.pandruvada@linux.intel.com>
         <1479250783-74336-2-git-send-email-srinivas.pandruvada@linux.intel.com>
         <20161117064954.GD4894@vireshk-i7>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Viresh,
On Thu, 2016-11-17 at 12:19 +0530, Viresh Kumar wrote:
> Hi Srinivas,
> 
> I don't think other platforms need it for now and so it is fine to
> add these to the driver itself.
Good to know. In this case I will proceed with change only local to
intel_pstate.

> 
> On 15-11-16, 14:59, Srinivas Pandruvada wrote:
> > 
> > +static ssize_t show_energy_performance_available_preferences(
> 
> Maybe a personal preference, but I would have broken the line after
> ssize_t instead of where you have done it.
I can change that.

> 
> > 
> > +				struct cpufreq_policy *policy,
> > char *buf)
> > +{
> > +static struct freq_attr *hwp_cpufreq_attrs[] = {
> > +	&energy_performance_preference,
> > +	&energy_performance_available_preferences,
> > +	NULL,
> > +};
> 
> What about adding these to intel_pstate_attr_group instead ?
Sure.

Thanks,
Srinivas