From: James Simmons <jsimmons@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>,
James Simmons <jsimmons@infradead.org>
Subject: [PATCH 09/19] staging: lustre: lnet: fill in real lnet_md_t
Date: Thu, 17 Nov 2016 14:35:47 -0500 [thread overview]
Message-ID: <1479411357-28979-10-git-send-email-jsimmons@infradead.org> (raw)
In-Reply-To: <1479411357-28979-1-git-send-email-jsimmons@infradead.org>
While checkpatch reported an alignment issue
its just ugly to fill in a data structure being
passed to a function. Instead fill in a lnet_md_t
on the stack and pass that to LNetMDBind.
Signed-off-by: James Simmons <jsimmons@infradead.org>
---
drivers/staging/lustre/lnet/lnet/router.c | 17 +++++++++--------
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
index 063ad55..8afa0ab 100644
--- a/drivers/staging/lustre/lnet/lnet/router.c
+++ b/drivers/staging/lustre/lnet/lnet/router.c
@@ -903,6 +903,7 @@ int lnet_get_rtr_pool_cfg(int idx, struct lnet_ioctl_pool_cfg *pool_cfg)
{
lnet_rc_data_t *rcd = NULL;
lnet_ping_info_t *pi;
+ lnet_md_t md;
int rc;
int i;
@@ -925,15 +926,15 @@ int lnet_get_rtr_pool_cfg(int idx, struct lnet_ioctl_pool_cfg *pool_cfg)
}
rcd->rcd_pinginfo = pi;
+ md.start = pi;
+ md.user_ptr = rcd;
+ md.length = LNET_PINGINFO_SIZE;
+ md.threshold = LNET_MD_THRESH_INF;
+ md.options = LNET_MD_TRUNCATE;
+ md.eq_handle = the_lnet.ln_rc_eqh;
+
LASSERT(!LNetHandleIsInvalid(the_lnet.ln_rc_eqh));
- rc = LNetMDBind((lnet_md_t){.start = pi,
- .user_ptr = rcd,
- .length = LNET_PINGINFO_SIZE,
- .threshold = LNET_MD_THRESH_INF,
- .options = LNET_MD_TRUNCATE,
- .eq_handle = the_lnet.ln_rc_eqh},
- LNET_UNLINK,
- &rcd->rcd_mdh);
+ rc = LNetMDBind(md, LNET_UNLINK, &rcd->rcd_mdh);
if (rc < 0) {
CERROR("Can't bind MD: %d\n", rc);
goto out;
--
1.7.1
next prev parent reply other threads:[~2016-11-17 19:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 19:35 [PATCH 00/19] LNet/libcfs checkpatch and style cleanups James Simmons
2016-11-17 19:35 ` [PATCH 01/19] staging: lustre: lnet: don't use bare unsigned James Simmons
2016-11-17 19:35 ` [PATCH 02/19] staging: lustre: lnet: resolve trailing */ errors James Simmons
2016-11-17 19:35 ` [PATCH 03/19] staging: lustre: libcfs: use static const char const * for a suffixes array James Simmons
2016-11-17 19:35 ` [PATCH 04/19] staging: lustre: libcfs: remove explicit test of NULL variable James Simmons
2016-11-17 19:35 ` [PATCH 05/19] staging: lustre: libcfs: fix aligment issue James Simmons
2016-11-17 19:35 ` [PATCH 06/19] staging: lustre: lnet: fix misspelled word destroy James Simmons
2016-11-17 19:35 ` [PATCH 07/19] staging: lustre: lnet: remove unused lib_me_dump James Simmons
2016-11-17 19:35 ` [PATCH 08/19] staging: lustre: lnet: missing blank line after declaration James Simmons
2016-11-17 19:35 ` James Simmons [this message]
2016-11-17 19:35 ` [PATCH 10/19] staging: lustre: lnet: replace uninitialized_var James Simmons
2016-11-17 19:35 ` [PATCH 11/19] staging: lustre: libcfs: remove != 0 testing James Simmons
2016-11-17 19:35 ` [PATCH 12/19] staging: lustre: libcfs: remove == " James Simmons
2016-11-18 11:01 ` Dan Carpenter
2016-11-18 16:46 ` James Simmons
2016-11-17 19:35 ` [PATCH 13/19] staging: lustre: libcfs: white space cleanup James Simmons
2016-11-17 19:35 ` [PATCH 14/19] staging: lustre: libcfs: fix misspelling of descriptor James Simmons
2016-11-17 19:35 ` [PATCH 15/19] staging: lustre: libcfs: Make char * array envp static constant James Simmons
2016-11-17 19:35 ` [PATCH 16/19] staging: lustre: libcfs: use pr_* instead of printk James Simmons
2016-11-17 19:35 ` [PATCH 17/19] staging: lustre: libcfs: remove use of __u* types James Simmons
2016-11-17 19:35 ` [PATCH 18/19] staging: lustre: lnet: use BIT macro in LNet selftest James Simmons
2016-11-17 19:35 ` [PATCH 19/19] staging: lustre: lnet: cleanup some of the > 80 line issues James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479411357-28979-10-git-send-email-jsimmons@infradead.org \
--to=jsimmons@infradead.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).