linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: akpm@linux-foundation.org
Cc: aryabinin@virtuozzo.com, joelaf@google.com, jszhang@marvell.com,
	chris@chris-wilson.co.uk, joaodias@google.com,
	linux-mm@kvack.org, linux-rt-users@vger.kernel.org,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 05/10] kernel/fork: use vfree_atomic() to free thread stack
Date: Fri, 18 Nov 2016 14:03:51 +0100	[thread overview]
Message-ID: <1479474236-4139-6-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1479474236-4139-1-git-send-email-hch@lst.de>

From: Andrey Ryabinin <aryabinin@virtuozzo.com>

vfree() is going to use sleeping lock. Thread stack freed in atomic
context, therefore we must use vfree_atomic() here.

Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
---
 kernel/fork.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index 997ac1d..cfee5ec 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -229,7 +229,7 @@ static inline void free_thread_stack(struct task_struct *tsk)
 		}
 		local_irq_restore(flags);
 
-		vfree(tsk->stack);
+		vfree_atomic(tsk->stack);
 		return;
 	}
 #endif
-- 
2.1.4

  parent reply	other threads:[~2016-11-18 13:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 13:03 reduce latency in __purge_vmap_area_lazy V2 Christoph Hellwig
2016-11-18 13:03 ` [PATCH 01/10] mm: remove free_unmap_vmap_area_noflush Christoph Hellwig
2016-11-18 13:03 ` [PATCH 02/10] mm: remove free_unmap_vmap_area_addr Christoph Hellwig
2016-11-18 13:03 ` [PATCH 03/10] mm: refactor __purge_vmap_area_lazy Christoph Hellwig
2016-11-18 13:03 ` [PATCH 04/10] mm: add vfree_atomic() Christoph Hellwig
2016-11-18 13:03 ` Christoph Hellwig [this message]
2016-11-18 13:03 ` [PATCH 06/10] x86/ldt: use vfree_atomic() to free ldt entries Christoph Hellwig
2016-11-18 13:03 ` [PATCH 07/10] mm: warn about vfree from atomic context Christoph Hellwig
2016-11-22 16:35   ` Andrey Ryabinin
2016-11-23  8:39     ` Christoph Hellwig
2016-11-18 13:03 ` [PATCH 08/10] mm: mark all calls into the vmalloc subsystem as potentially sleeping Christoph Hellwig
2016-11-18 13:03 ` [PATCH 09/10] mm: turn vmap_purge_lock into a mutex Christoph Hellwig
2016-11-18 13:03 ` [PATCH 10/10] mm: add preempt points into __purge_vmap_area_lazy Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479474236-4139-6-git-send-email-hch@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=joaodias@google.com \
    --cc=joelaf@google.com \
    --cc=jszhang@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).