From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754244AbcKRNEc (ORCPT ); Fri, 18 Nov 2016 08:04:32 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:54973 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754134AbcKRNEa (ORCPT ); Fri, 18 Nov 2016 08:04:30 -0500 From: Christoph Hellwig To: akpm@linux-foundation.org Cc: aryabinin@virtuozzo.com, joelaf@google.com, jszhang@marvell.com, chris@chris-wilson.co.uk, joaodias@google.com, linux-mm@kvack.org, linux-rt-users@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/10] mm: warn about vfree from atomic context Date: Fri, 18 Nov 2016 14:03:53 +0100 Message-Id: <1479474236-4139-8-git-send-email-hch@lst.de> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1479474236-4139-1-git-send-email-hch@lst.de> References: <1479474236-4139-1-git-send-email-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We can't handle vfree itself from atomic context, but callers can explicitly use vfree_atomic instead, which defers the actual vfree to a workqueue. Unfortunately in_atomic does not work on non-preemptible kernels, so we can't just do the right thing by default. Signed-off-by: Christoph Hellwig --- mm/vmalloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 80f3fae..e2030b4 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1530,6 +1530,7 @@ void vfree_atomic(const void *addr) void vfree(const void *addr) { BUG_ON(in_nmi()); + WARN_ON_ONCE(in_atomic()); kmemleak_free(addr); -- 2.1.4