From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S938837AbcKXKsM convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Nov 2016 05:48:12 -0500
Received: from shell.v3.sk ([92.60.52.57]:56681 "EHLO shell.v3.sk"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933774AbcKXKsL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Nov 2016 05:48:11 -0500
Message-ID: <1479984481.8204.0.camel@v3.sk>
Subject: Re: [patch] char/pcmcia: add some error checking in scr24x_read()
From: Lubomir Rintel <lkundrak@v3.sk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Thu, 24 Nov 2016 11:48:01 +0100
In-Reply-To: <20161124104623.GA17225@mwanda>
References: <20161124104623.GA17225@mwanda>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.1 (3.22.1-2.fc25) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2016-11-24 at 13:46 +0300, Dan Carpenter wrote:
> The "ret = " assignment seems to have accidentally been left off.
> 
> Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface
> driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/char/pcmcia/scr24x_cs.c
> b/drivers/char/pcmcia/scr24x_cs.c
> index 4f215ce..8523ec5 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -157,7 +157,7 @@ static ssize_t scr24x_read(struct file *filp,
> char __user *buf, size_t count,
>  		ret = -EIO;
>  		goto out;
>  	}
> -	read_chunk(dev, CCID_HEADER_SIZE, len);
> +	ret = read_chunk(dev, CCID_HEADER_SIZE, len);
>  	if (ret < 0)
>  		goto out;


Acked-by: Lubomir Rintel <lkundrak@v3.sk>

Thank you,
Lubo