Re: [PATCH 3/3] hwmon: tmp108: Update driver to use hwmon_chip_info.

John Muir
2016-11-28T02:10:57Z

> On 2016.11.27, at 15:00 , Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Sat, Nov 26, 2016 at 09:15:37PM -0800, John Muir wrote:
>> Move the tmp108 driver from hwmon attribute groups to
>> hwmon_chip_info.
>>
>> Signed-off-by: John Muir <john@jmuir.com>
>> ---
>
> Hi John,
>
> please have a look at the following patch.
>
> Something else: Symbolic permissions are out of favor nowadays.
> You might instead just use 0644 / 0444. Not that I really care,
> but it prevents the inevitable follow-up patches.
>

Hi Guenter,

Thank you for this patch. I will attempt to implement the same changes using the older interfaces in my 4.4 implementation. I will incorporate your changes and other comments as soon as I can (early this week) and re-send my patch series.

Cheers,

John.