Re: [PATCH v3 33/33] Reimplement IDR and IDA using the radix tree

Andrew Morton
2016-12-06T21:25:16Z

On Tue, 6 Dec 2016 21:17:52 +0000 Matthew Wilcox <mawilcox@microsoft.com> wrote:

> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> > On Mon, 28 Nov 2016 13:50:37 -0800 Matthew Wilcox
> > <mawilcox@linuxonhyperv.com> wrote:
> > > include/linux/idr.h | 132 ++--
> > > include/linux/radix-tree.h | 5 +-
> > > init/main.c | 3 +-
> > > lib/idr.c | 1078 -------------------------------
> > > lib/radix-tree.c | 632 ++++++++++++++++--
> >
> > hm. It's just a cosmetic issue, but perhaps the idr
> > wrappers-around-radix-tree code should be in a different .c file.
>
> I can put some of them back into idr.c -- there's a couple of routines left in there still, so adding some more won't hurt.

OK. Sometime. Let's see how this lot pans out as-is for now?