From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757521AbcLAAtC (ORCPT ); Wed, 30 Nov 2016 19:49:02 -0500 Received: from mailgw02.mediatek.com ([66.228.70.112]:49068 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755292AbcLAAtA (ORCPT ); Wed, 30 Nov 2016 19:49:00 -0500 X-Greylist: delayed 301 seconds by postgrey-1.27 at vger.kernel.org; Wed, 30 Nov 2016 19:48:59 EST Message-ID: <1480553030.29122.7.camel@mussux00> Subject: Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode From: Hongzhou Yang To: Matthias Brugger CC: chunfeng yun , Linus Walleij , Maoguang Meng , Yingjoe Chen , Greg Kroah-Hartman , Felipe Balbi , Mathias Nyman , Alan Stern , Rob Herring , Mark Rutland , Ian Campbell , Sergei Shtylyov , Pawel Moll , Kumar Gala , Sascha Hauer , Biao Huang , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , "linux-gpio@vger.kernel.org" , Date: Wed, 30 Nov 2016 16:43:50 -0800 In-Reply-To: <42f5df18-2edd-08f2-a833-9c92ac85e87c@gmail.com> References: <1462868614-20602-1-git-send-email-chunfeng.yun@mediatek.com> <1462868614-20602-7-git-send-email-chunfeng.yun@mediatek.com> <1462991546.11623.3.camel@mussux00> <1463017282.11651.82.camel@mhfsdcap03> <1463018942.1608.5.camel@mussux00> <1463021701.25171.5.camel@mussux00> <42f5df18-2edd-08f2-a833-9c92ac85e87c@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N X-TM-AS-Product-Ver: SMEX-10.2.0.3308-8.000.1202-22730.004 X-TM-AS-Result: No--25.004900-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-11-23 at 19:32 +0100, Matthias Brugger wrote: > Hi Hongzhou, > > On 12/05/16 04:55, Hongzhou Yang wrote: > > On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote: > >> On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote: > >>> Hi, > >>> > >>> On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote: > >>>> On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: > >>>>> On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun > >>>>> wrote: > >>>>> > >>>>>> the default mode of GPIO16 pin is gpio, when set EINT16 to > >>>>>> IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be > >>>>>> fixed when set its default mode as usb iddig. > >>>>>> > >>>>>> Signed-off-by: Chunfeng Yun > >>>>> > >>>> > >>>> Chunfeng, GPIO16 can be used as EINT16 mode, but the pinmux should be 0. > >>>> If you want to set its default mode to iddig, you should set it in dts. > >>>> > >>> I set it in DTS, but it didn't work, because when usb driver requested > >>> IRQ, pinmux was switched back to default mode set by > >>> MTK_EINT_FUNCTION(). > >>> > >> > >> After confirmed, there are something wrong with data sheet and pinmux > >> table, and GPIO16 can only receive interrupt by mode 1. So > >> > >> Acked-by: Hongzhou Yang > >> > > > > Linus, > > > > We find there are some other pins still have the same problem, so please > > hold on it. Sorry for so much noise. > > > > Did you made any progress on this? I didn't see any patch on the mailing > list. > > Regards, > Matthias Hi Matthias, Sorry for the late reply. I have double confirmed with HW designer, other special EINTs are built-in and they are using internal signal, they are not triggered by GPIO, only GPIO16 should set to mode 1. And, Chunfeng already re-sent this patch. Thank you very much. Yours, Hongzhou