From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756715AbcLALSD (ORCPT ); Thu, 1 Dec 2016 06:18:03 -0500 Received: from mga05.intel.com ([192.55.52.43]:32783 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbcLALSB (ORCPT ); Thu, 1 Dec 2016 06:18:01 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,724,1477983600"; d="scan'208";a="37607425" From: "Luc, Piotr" To: "lenb@kernel.org" CC: "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "linux-pm@vger.kernel.org" , "mchehab@kernel.org" , "x86@kernel.org" , "dougthompson@xmission.com" , "hpa@zytor.com" , "viresh.kumar@linaro.org" , "mingo@redhat.com" , "rjw@rjwysocki.net" , "srinivas.pandruvada@linux.intel.com" , "bp@alien8.de" , "linux-edac@vger.kernel.org" Subject: Re: [RESEND PATCH 11/11] tools/power turbostat: enable turbostat to support Knights Mill (KNM) Thread-Topic: [RESEND PATCH 11/11] tools/power turbostat: enable turbostat to support Knights Mill (KNM) Thread-Index: AQHSS57H0ZLp+LhB30GzQfwZc7LKzKDy8b6A Date: Thu, 1 Dec 2016 11:17:56 +0000 Message-ID: <1480591045.4677.45.camel@intel.com> References: <20161013153105.2517-1-piotr.luc@intel.com> <20161013153105.2517-12-piotr.luc@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.138.164] Content-Type: text/plain; charset="utf-8" Content-ID: <7C5E99D854E1EC40A92F33CF9B95CEFC@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uB1BI76Z001716 On Thu, 2016-12-01 at 01:47 -0500, Len Brown wrote: > Piotr, > Thanks for sending the patch, I've made this change to my turbostat > branch for 4.10. > > I did not apply your patch directly because for some reason it didn't > appear in patchwork for linux-pm, > only for lkml, which I do not review. The missing from linux-pm was my mistake due to lack of experience and perspicacity; I did not add the linux-pm list to cc because I could not find an entry for turbostat on MAINTAINERS file. Probably, it is mentioned implicitly but I did not come across it. > > Also, your patch depended on your style update patch to use the model > # macros. > Unfortunately what you did not know was that I'd already applied a > slightly different style update patch. > (and it was my fault that I did not push it upstream before my summer > sabbatical, sorry) NP, this was an easy change made automatically by my script. > > In general, though, a good strategy when mixing style and > functionality patches > is to do the functionality first.  The reason is both that style > patches tend to conflict more, > and you don't want them to hold up the functionality. > Also, if your functionality patch does not depend on style, > it is easier to backport to distros who avoid style updates. Thanks for the tip. However, in this case, I got comments to use the macros instead raw numbers in my patch and remove unnecessary comments. It caused that the style patch came first. Thanks Piotr