From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755399AbcLAXvQ (ORCPT ); Thu, 1 Dec 2016 18:51:16 -0500 Received: from mga01.intel.com ([192.55.52.88]:29823 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbcLAXvO (ORCPT ); Thu, 1 Dec 2016 18:51:14 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,284,1477983600"; d="scan'208";a="198083264" Message-ID: <1480636273.2442.0.camel@linux.intel.com> Subject: Re: [PATCH] HID: intel_ish-hid: use %pUL for uuid formatting From: Srinivas Pandruvada To: Benjamin Tissoires , Rasmus Villemoes Cc: Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 01 Dec 2016 15:51:13 -0800 In-Reply-To: <20161201142110.GB1280@mail.corp.redhat.com> References: <1480546127-3539-1-git-send-email-linux@rasmusvillemoes.dk> <20161201142110.GB1280@mail.corp.redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-12-01 at 15:21 +0100, Benjamin Tissoires wrote: > On Nov 30 2016 or thereabouts, Rasmus Villemoes wrote: > > > > We have the %pU printf extension for doing exactly this. Saves some > > .text, and is likely also a little faster. > > > > Signed-off-by: Rasmus Villemoes > > Reviewed-by: Benjamin Tissoires Acked-by: Srinivas Pandruvada > > > > > --- > >  drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +-------- > >  1 file changed, 1 insertion(+), 8 deletions(-) > > > > diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c > > b/drivers/hid/intel-ish-hid/ishtp/bus.c > > index 256521509d20..f4cbc744e657 100644 > > --- a/drivers/hid/intel-ish-hid/ishtp/bus.c > > +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c > > @@ -585,14 +585,7 @@ int ishtp_bus_new_client(struct ishtp_device > > *dev) > >    */ > >   i = dev->fw_client_presentation_num - 1; > >   device_uuid = dev->fw_clients[i].props.protocol_name; > > - dev_name = kasprintf(GFP_KERNEL, > > - "{%02X%02X%02X%02X-%02X%02X-%02X%02X-%02X%02X- > > %02X%02X%02X%02X%02X%02X}", > > - device_uuid.b[3], device_uuid.b[2], > > device_uuid.b[1], > > - device_uuid.b[0], device_uuid.b[5], > > device_uuid.b[4], > > - device_uuid.b[7], device_uuid.b[6], > > device_uuid.b[8], > > - device_uuid.b[9], device_uuid.b[10], > > device_uuid.b[11], > > - device_uuid.b[12], device_uuid.b[13], > > device_uuid.b[14], > > - device_uuid.b[15]); > > + dev_name = kasprintf(GFP_KERNEL, "{%pUL}", device_uuid.b); > >   if (!dev_name) > >   return -ENOMEM; > >   > > --  > > 2.1.4 > >