From: Oleg Drokin <green@linuxhacker.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>,
Oleg Drokin <green@linuxhacker.ru>
Subject: [PATCH 6/8] staging/lustre: Declare lu_context/session_tags_default
Date: Wed, 7 Dec 2016 17:41:32 -0500 [thread overview]
Message-ID: <1481150494-1853127-7-git-send-email-green@linuxhacker.ru> (raw)
In-Reply-To: <1481150494-1853127-1-git-send-email-green@linuxhacker.ru>
Make the declaration in a header, not as an extern in a C file,
that is frowned upon.
This also makes sparse a little bit more happy.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
drivers/staging/lustre/lustre/include/lu_object.h | 3 +++
drivers/staging/lustre/lustre/obdclass/cl_object.c | 3 +--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lu_object.h b/drivers/staging/lustre/lustre/include/lu_object.h
index 260643e..69b2812 100644
--- a/drivers/staging/lustre/lustre/include/lu_object.h
+++ b/drivers/staging/lustre/lustre/include/lu_object.h
@@ -1326,5 +1326,8 @@ void lu_buf_realloc(struct lu_buf *buf, size_t size);
int lu_buf_check_and_grow(struct lu_buf *buf, size_t len);
struct lu_buf *lu_buf_check_and_alloc(struct lu_buf *buf, size_t len);
+extern __u32 lu_context_tags_default;
+extern __u32 lu_session_tags_default;
+
/** @} lu */
#endif /* __LUSTRE_LU_OBJECT_H */
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
index f5d4e23..703cb67 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
@@ -54,6 +54,7 @@
#include <linux/list.h>
#include "../../include/linux/libcfs/libcfs_hash.h" /* for cfs_hash stuff */
#include "../include/cl_object.h"
+#include "../include/lu_object.h"
#include "cl_internal.h"
static struct kmem_cache *cl_env_kmem;
@@ -61,8 +62,6 @@ static struct kmem_cache *cl_env_kmem;
/** Lock class of cl_object_header::coh_attr_guard */
static struct lock_class_key cl_attr_guard_class;
-extern __u32 lu_context_tags_default;
-extern __u32 lu_session_tags_default;
/**
* Initialize cl_object_header.
*/
--
2.7.4
next prev parent reply other threads:[~2016-12-07 22:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 22:41 [PATCH 0/8] Sparse warning fixes in Lustre Oleg Drokin
2016-12-07 22:41 ` [PATCH 1/8] staging/lustre/llite: move root_squash from sysfs to debugfs Oleg Drokin
2016-12-08 0:44 ` James Simmons
2016-12-07 22:41 ` [PATCH 2/8] staging/lustre/ldlm: Correct itree_overlap_cb return type Oleg Drokin
2016-12-08 0:16 ` James Simmons
2016-12-08 0:21 ` James Simmons
2016-12-07 22:41 ` [PATCH 3/8] staging/lustre/llite: mark ll_io_init() static Oleg Drokin
2016-12-08 0:24 ` James Simmons
2016-12-07 22:41 ` [PATCH 4/8] staging/lustre/lov: make lov_lsm_alloc() static Oleg Drokin
2016-12-08 0:23 ` James Simmons
2016-12-07 22:41 ` [PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header Oleg Drokin
2016-12-08 0:22 ` James Simmons
2016-12-08 0:23 ` James Simmons
2016-12-07 22:41 ` Oleg Drokin [this message]
2016-12-08 0:28 ` [PATCH 6/8] staging/lustre: Declare lu_context/session_tags_default James Simmons
2016-12-07 22:41 ` [PATCH 7/8] staging/lustre: Move lov_read_and_clear_async_rc declaration Oleg Drokin
2016-12-08 0:24 ` James Simmons
2016-12-07 22:41 ` [PATCH 8/8] staging/lustre/ptlrpc: Move nrs_conf_fifo extern to a header Oleg Drokin
2016-12-08 0:25 ` James Simmons
2016-12-08 0:27 ` James Simmons
2016-12-07 23:46 ` [PATCH 0/8] Sparse warning fixes in Lustre Al Viro
2016-12-13 4:07 ` Oleg Drokin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481150494-1853127-7-git-send-email-green@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).