From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753535AbcLHVKk (ORCPT ); Thu, 8 Dec 2016 16:10:40 -0500 Received: from smtprelay0240.hostedemail.com ([216.40.44.240]:59355 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751722AbcLHVKj (ORCPT ); Thu, 8 Dec 2016 16:10:39 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3867:4321:4605:5007:6742:6743:7576:10004:10400:10848:11026:11232:11658:11914:12043:12048:12296:12438:12740:12760:13069:13255:13311:13357:13439:14181:14659:14721:21080:21451,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: front29_3ecf3c309bc30 X-Filterd-Recvd-Size: 2198 Message-ID: <1481231430.5946.34.camel@perches.com> Subject: Re: [PATCH v18 03/15] clocksource/drivers/arm_arch_timer: Improve printk relevant code From: Joe Perches To: fu.wei@linaro.org, rjw@rjwysocki.net, lenb@kernel.org, daniel.lezcano@linaro.org, tglx@linutronix.de, marc.zyngier@arm.com, mark.rutland@arm.com, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, hanjun.guo@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linaro-acpi@lists.linaro.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rruigrok@codeaurora.org, harba@codeaurora.org, cov@codeaurora.org, timur@codeaurora.org, graeme.gregory@linaro.org, al.stone@linaro.org, jcm@redhat.com, wei@redhat.com, arnd@arndb.de, catalin.marinas@arm.com, will.deacon@arm.com, Suravee.Suthikulpanit@amd.com, leo.duran@amd.com, wim@iguana.be, linux@roeck-us.net, linux-watchdog@vger.kernel.org, tn@semihalf.com, christoffer.dall@linaro.org, julien.grall@arm.com Date: Thu, 08 Dec 2016 13:10:30 -0800 In-Reply-To: <20161208173319.6618-4-fu.wei@linaro.org> References: <20161208173319.6618-1-fu.wei@linaro.org> <20161208173319.6618-4-fu.wei@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-12-09 at 01:33 +0800, fu.wei@linaro.org wrote: > From: Fu Wei > > This patch defines pr_fmt(fmt) for all pr_* functions, > then the pr_* doesn't need to add "arch_timer:" everytime. trivia: > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c [] > @@ -966,7 +967,7 @@ static int __init arch_timer_mem_init(struct device_node *np) > > ret = -EINVAL; > if (!irq) { > - pr_err("arch_timer: Frame missing %s irq", > + pr_err("Frame missing %s irq", > arch_timer_mem_use_virtual ? "virt" : "phys"); > goto out; > } Missing terminating newline pr_err("Frame missing %s irq\n",