From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753007AbcLJL17 (ORCPT ); Sat, 10 Dec 2016 06:27:59 -0500 Received: from smtprelay0155.hostedemail.com ([216.40.44.155]:57040 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751388AbcLJL15 (ORCPT ); Sat, 10 Dec 2016 06:27:57 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:3871:3872:4321:5007:6117:6119:7903:10004:10400:10848:11026:11232:11658:11914:12740:12760:13069:13311:13357:13439:14181:14659:14721:21080:30003:30054:30064:30075:30091,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:error,Custom_rules:0:0:0,LFtime:2000,LUA_SUMMARY:none X-HE-Tag: heat60_27b2568f76552 X-Filterd-Recvd-Size: 1619 Message-ID: <1481369270.5946.51.camel@perches.com> Subject: Re: [patch] nvme-fabrics: correct some printk information From: Joe Perches To: Dan Carpenter , James Smart Cc: Keith Busch , Jens Axboe , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Sat, 10 Dec 2016 03:27:50 -0800 In-Reply-To: <20161210090618.GA11680@elgon.mountain> References: <20161210090618.GA11680@elgon.mountain> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-12-10 at 12:06 +0300, Dan Carpenter wrote: > We really don't care where "ctrl" is on the stack since we're just > returning soon what we want is the actual ctrl pointer itself. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c [] > @@ -2402,7 +2402,7 @@ enum blk_eh_timer_return > > dev_info(ctrl->ctrl.device, > "NVME-FC{%d}: new ctrl: NQN \"%s\" (%p)\n", > - ctrl->cnum, ctrl->ctrl.opts->subsysnqn, &ctrl); > + ctrl->cnum, ctrl->ctrl.opts->subsysnqn, ctrl); Found by script or inspection? If by script, it seems unlikely there's only 1 instance where an address of an automatic pointer type is used incorrectly.